From fa242fec31215f05e5fc4d163e0e574872664bb9 Mon Sep 17 00:00:00 2001 From: Agata Date: Tue, 1 Oct 2019 21:50:13 +0200 Subject: [PATCH] Fixed third argument in VarDumperTestTrait. --- docs/AllRectorsOverview.md | 10 +++++----- .../VarDumper/VarDumperTestTraitMethodArgsRector.php | 12 ++++++------ .../Fixture/fixture.php.inc | 6 +++--- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/docs/AllRectorsOverview.md b/docs/AllRectorsOverview.md index d4d919a49da2..0f7a24cb42e5 100644 --- a/docs/AllRectorsOverview.md +++ b/docs/AllRectorsOverview.md @@ -5721,16 +5721,16 @@ Changes Process string argument to an array - class: `Rector\Symfony\Rector\VarDumper\VarDumperTestTraitMethodArgsRector` -Adds new `$format` argument in `VarDumperTestTrait->assertDumpEquals()` in Validator in Symfony. +Adds a new `$filter` argument in `VarDumperTestTrait->assertDumpEquals()` and `VarDumperTestTrait->assertDumpMatchesFormat()` in Validator in Symfony. ```diff --$varDumperTestTrait->assertDumpEquals($dump, $data, $mesage = ""); -+$varDumperTestTrait->assertDumpEquals($dump, $data, $context = null, $mesage = ""); +-$varDumperTestTrait->assertDumpEquals($dump, $data, $message = ""); ++$varDumperTestTrait->assertDumpEquals($dump, $data, $filter = 0, $message = ""); ``` ```diff --$varDumperTestTrait->assertDumpMatchesFormat($dump, $format, $mesage = ""); -+$varDumperTestTrait->assertDumpMatchesFormat($dump, $format, $context = null, $mesage = ""); +-$varDumperTestTrait->assertDumpMatchesFormat($dump, $data, $message = ""); ++$varDumperTestTrait->assertDumpMatchesFormat($dump, $data, $filter = 0, $message = ""); ```
diff --git a/packages/Symfony/src/Rector/VarDumper/VarDumperTestTraitMethodArgsRector.php b/packages/Symfony/src/Rector/VarDumper/VarDumperTestTraitMethodArgsRector.php index f2837d408fef..218aee80acc0 100644 --- a/packages/Symfony/src/Rector/VarDumper/VarDumperTestTraitMethodArgsRector.php +++ b/packages/Symfony/src/Rector/VarDumper/VarDumperTestTraitMethodArgsRector.php @@ -28,15 +28,15 @@ public function __construct(string $traitName = 'Symfony\Component\VarDumper\Tes public function getDefinition(): RectorDefinition { return new RectorDefinition( - 'Adds new `$format` argument in `VarDumperTestTrait->assertDumpEquals()` in Validator in Symfony.', + 'Adds a new `$filter` argument in `VarDumperTestTrait->assertDumpEquals()` and `VarDumperTestTrait->assertDumpMatchesFormat()` in Validator in Symfony.', [ new CodeSample( - '$varDumperTestTrait->assertDumpEquals($dump, $data, $mesage = "");', - '$varDumperTestTrait->assertDumpEquals($dump, $data, $context = null, $mesage = "");' + '$varDumperTestTrait->assertDumpEquals($dump, $data, $message = "");', + '$varDumperTestTrait->assertDumpEquals($dump, $data, $filter = 0, $message = "");' ), new CodeSample( - '$varDumperTestTrait->assertDumpMatchesFormat($dump, $format, $mesage = "");', - '$varDumperTestTrait->assertDumpMatchesFormat($dump, $format, $context = null, $mesage = "");' + '$varDumperTestTrait->assertDumpMatchesFormat($dump, $data, $message = "");', + '$varDumperTestTrait->assertDumpMatchesFormat($dump, $data, $filter = 0, $message = "");' ), ] ); @@ -69,7 +69,7 @@ public function refactor(Node $node): ?Node if ($node->args[2]->value instanceof String_) { $node->args[3] = $node->args[2]; - $node->args[2] = $this->createArg($this->createNull()); + $node->args[2] = $this->createArg(0); return $node; } diff --git a/packages/Symfony/tests/Rector/VarDumper/VarDumperTestTraitMethodArgsRector/Fixture/fixture.php.inc b/packages/Symfony/tests/Rector/VarDumper/VarDumperTestTraitMethodArgsRector/Fixture/fixture.php.inc index f4516827c21b..8e2aa4d33779 100644 --- a/packages/Symfony/tests/Rector/VarDumper/VarDumperTestTraitMethodArgsRector/Fixture/fixture.php.inc +++ b/packages/Symfony/tests/Rector/VarDumper/VarDumperTestTraitMethodArgsRector/Fixture/fixture.php.inc @@ -6,7 +6,7 @@ function varDumperTrait() { $trait = new ClassWithVarDumperTrait(); $trait->assertDumpEquals($dump, $data, 'Some message'); - $trait->assertDumpMatchesFormat($dump, $format, 'Some message'); + $trait->assertDumpMatchesFormat($dump, $data, 'Some message'); } ?> @@ -18,8 +18,8 @@ use Rector\Symfony\Tests\Rector\VarDumper\VarDumperTestTraitMethodArgsRector\Sou function varDumperTrait() { $trait = new ClassWithVarDumperTrait(); - $trait->assertDumpEquals($dump, $data, null, 'Some message'); - $trait->assertDumpMatchesFormat($dump, $format, null, 'Some message'); + $trait->assertDumpEquals($dump, $data, 0, 'Some message'); + $trait->assertDumpMatchesFormat($dump, $data, 0, 'Some message'); } ?>