From 90a4056134a64e442cfbfc27eeb4e6b5b15dec74 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Tue, 8 Oct 2019 17:02:51 +0100 Subject: [PATCH 1/4] add highlight to bug report --- .github/ISSUE_TEMPLATE/1_Bug_report.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/1_Bug_report.md b/.github/ISSUE_TEMPLATE/1_Bug_report.md index 932394bdc1c3..4cc0515a1970 100644 --- a/.github/ISSUE_TEMPLATE/1_Bug_report.md +++ b/.github/ISSUE_TEMPLATE/1_Bug_report.md @@ -20,4 +20,10 @@ about: Report errors and problems +```php + Date: Tue, 8 Oct 2019 17:02:56 +0100 Subject: [PATCH 2/4] add test reference --- packages/Sensio/src/Helper/TemplateGuesser.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/Sensio/src/Helper/TemplateGuesser.php b/packages/Sensio/src/Helper/TemplateGuesser.php index 4159b04716b7..610105fff6c9 100644 --- a/packages/Sensio/src/Helper/TemplateGuesser.php +++ b/packages/Sensio/src/Helper/TemplateGuesser.php @@ -8,6 +8,10 @@ use Rector\NodeTypeResolver\Node\AttributeKey; use Rector\PhpParser\Node\Resolver\NameResolver; +/** + * @see \Rector\Sensio\Tests\Rector\FrameworkExtraBundle\TemplateAnnotationRector\TemplateAnnotationVersion3RectorTest + * @see \Rector\Sensio\Tests\Rector\FrameworkExtraBundle\TemplateAnnotationRector\TemplateAnnotationVersion5RectorTest + */ final class TemplateGuesser { /** From 76cf03b0925d78e70939b62c86249ed964907813 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Tue, 8 Oct 2019 17:04:06 +0100 Subject: [PATCH 3/4] add rector version to bug report --- .github/ISSUE_TEMPLATE/1_Bug_report.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/ISSUE_TEMPLATE/1_Bug_report.md b/.github/ISSUE_TEMPLATE/1_Bug_report.md index 4cc0515a1970..09b80d757505 100644 --- a/.github/ISSUE_TEMPLATE/1_Bug_report.md +++ b/.github/ISSUE_TEMPLATE/1_Bug_report.md @@ -7,6 +7,7 @@ about: Report errors and problems | Subject | Details | | :------------- | :----------------------------------------------------------- | +| Rector version | e.g. v0.5.15 (invoke `vendor/bin/rector --version`) | | PHP version | e.g. PHP 7.3 (invoke `php -v`) | | Full Command | e.g. vendor/bin/rector process /src --set dead-code --debug | From a38b60bf27e39eedf04f95025c06ae19210f4125 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Tue, 8 Oct 2019 17:06:51 +0100 Subject: [PATCH 4/4] make SensioTemlateTagValue open to nullable valubes --- .../Sensio/SensioTemplateTagValueNode.php | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/BetterPhpDocParser/src/PhpDocNode/Sensio/SensioTemplateTagValueNode.php b/packages/BetterPhpDocParser/src/PhpDocNode/Sensio/SensioTemplateTagValueNode.php index d82d5966743e..5acdc987db51 100644 --- a/packages/BetterPhpDocParser/src/PhpDocNode/Sensio/SensioTemplateTagValueNode.php +++ b/packages/BetterPhpDocParser/src/PhpDocNode/Sensio/SensioTemplateTagValueNode.php @@ -23,20 +23,20 @@ final class SensioTemplateTagValueNode extends AbstractTagValueNode private $template; /** - * @var mixed[] + * @var mixed[]|null */ - private $owner = []; + private $owner; /** - * @var mixed[] + * @var mixed[]|null */ - private $vars = []; + private $vars; /** - * @param mixed[] $owner - * @param mixed[] $vars + * @param mixed[]|null $owner + * @param mixed[]|null $vars */ - public function __construct(?string $template, array $owner, array $vars) + public function __construct(?string $template, ?array $owner = null, ?array $vars = null) { $this->template = $template; $this->owner = $owner;