From aa3e1249d460629c75cc024d31450d105605812b Mon Sep 17 00:00:00 2001 From: Stephan Vierkant Date: Fri, 24 Apr 2020 09:49:03 +0200 Subject: [PATCH 1/2] Symfony route with expose option (FosJsRoutingBundle) --- .../SymfonyRoute/RouteWithExposeOption.php | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 packages/better-php-doc-parser/tests/PhpDocParser/TagValueNodeReprint/Fixture/SymfonyRoute/RouteWithExposeOption.php diff --git a/packages/better-php-doc-parser/tests/PhpDocParser/TagValueNodeReprint/Fixture/SymfonyRoute/RouteWithExposeOption.php b/packages/better-php-doc-parser/tests/PhpDocParser/TagValueNodeReprint/Fixture/SymfonyRoute/RouteWithExposeOption.php new file mode 100644 index 000000000000..56a0006b0880 --- /dev/null +++ b/packages/better-php-doc-parser/tests/PhpDocParser/TagValueNodeReprint/Fixture/SymfonyRoute/RouteWithExposeOption.php @@ -0,0 +1,20 @@ + Date: Thu, 30 Apr 2020 13:45:27 +0200 Subject: [PATCH 2/2] No need to have an extra tests. Other tests had : instead of =, that's the underlying problem. --- .../SymfonyRoute/RouteWithCondition.php | 4 ++-- .../SymfonyRoute/RouteWithExposeOption.php | 20 ------------------- .../Fixture/SymfonyRoute/SomeClassMethod.php | 2 +- 3 files changed, 3 insertions(+), 23 deletions(-) delete mode 100644 packages/better-php-doc-parser/tests/PhpDocParser/TagValueNodeReprint/Fixture/SymfonyRoute/RouteWithExposeOption.php diff --git a/packages/better-php-doc-parser/tests/PhpDocParser/TagValueNodeReprint/Fixture/SymfonyRoute/RouteWithCondition.php b/packages/better-php-doc-parser/tests/PhpDocParser/TagValueNodeReprint/Fixture/SymfonyRoute/RouteWithCondition.php index 610f34874dd4..8f30f0ddad72 100644 --- a/packages/better-php-doc-parser/tests/PhpDocParser/TagValueNodeReprint/Fixture/SymfonyRoute/RouteWithCondition.php +++ b/packages/better-php-doc-parser/tests/PhpDocParser/TagValueNodeReprint/Fixture/SymfonyRoute/RouteWithCondition.php @@ -12,8 +12,8 @@ final class RouteWithCondition * @Route( * path="/remove/{object}/{when}/{slot}", * name="route_name", - * requirements={"object":"\d{1,9}", "when":"\d{4}-\d{2}-\d{2}", "slot":"\d{1,9}"}, - * options={"expose":true, "i18n":false}, + * requirements={"object"="\d{1,9}", "when"="\d{4}-\d{2}-\d{2}", "slot"="\d{1,9}"}, + * options={"expose"=true, "i18n"=false}, * condition="request.isXmlHttpRequest()" * ) */ diff --git a/packages/better-php-doc-parser/tests/PhpDocParser/TagValueNodeReprint/Fixture/SymfonyRoute/RouteWithExposeOption.php b/packages/better-php-doc-parser/tests/PhpDocParser/TagValueNodeReprint/Fixture/SymfonyRoute/RouteWithExposeOption.php deleted file mode 100644 index 56a0006b0880..000000000000 --- a/packages/better-php-doc-parser/tests/PhpDocParser/TagValueNodeReprint/Fixture/SymfonyRoute/RouteWithExposeOption.php +++ /dev/null @@ -1,20 +0,0 @@ -