From b5d2b8241876f70c14fedf6e3e054ea5e74aafbf Mon Sep 17 00:00:00 2001 From: Ofer Shaal Date: Wed, 20 May 2020 17:29:21 -0400 Subject: [PATCH 1/3] Keep an empty docblock as is --- .../better-php-doc-parser/src/Printer/PhpDocInfoPrinter.php | 5 ----- 1 file changed, 5 deletions(-) diff --git a/packages/better-php-doc-parser/src/Printer/PhpDocInfoPrinter.php b/packages/better-php-doc-parser/src/Printer/PhpDocInfoPrinter.php index 853c844d9025..682bca290c85 100644 --- a/packages/better-php-doc-parser/src/Printer/PhpDocInfoPrinter.php +++ b/packages/better-php-doc-parser/src/Printer/PhpDocInfoPrinter.php @@ -122,11 +122,6 @@ public function printFormatPreserving(PhpDocInfo $phpDocInfo): string private function printPhpDocNode(AttributeAwarePhpDocNode $attributeAwarePhpDocNode): string { - // no nodes were, so empty doc - if ($this->isPhpDocNodeEmpty($attributeAwarePhpDocNode)) { - return ''; - } - $this->currentTokenPosition = 0; $output = ''; From 48e83ea1bb96b5f903e9e04a25a77b9ceb5eaf31 Mon Sep 17 00:00:00 2001 From: Ofer Shaal Date: Thu, 21 May 2020 04:06:13 -0400 Subject: [PATCH 2/3] Remove the function isPhpDocNodeEmpty() that is no longer being used --- .../src/Printer/PhpDocInfoPrinter.php | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/packages/better-php-doc-parser/src/Printer/PhpDocInfoPrinter.php b/packages/better-php-doc-parser/src/Printer/PhpDocInfoPrinter.php index 682bca290c85..5b4a2ab15318 100644 --- a/packages/better-php-doc-parser/src/Printer/PhpDocInfoPrinter.php +++ b/packages/better-php-doc-parser/src/Printer/PhpDocInfoPrinter.php @@ -153,25 +153,6 @@ private function removeExtraSpacesAfterAsterisk(string $phpDocString): string return Strings::replace($phpDocString, '#([^*])\*[ \t]+$#sm', '$1*'); } - private function isPhpDocNodeEmpty(PhpDocNode $phpDocNode): bool - { - if (count($phpDocNode->children) === 0) { - return true; - } - - foreach ($phpDocNode->children as $phpDocChildNode) { - if ($phpDocChildNode instanceof PhpDocTextNode) { - if ($phpDocChildNode->text !== '') { - return false; - } - } else { - return false; - } - } - - return true; - } - private function printNode( AttributeAwareNodeInterface $attributeAwareNode, ?StartEndValueObject $startEndValueObject = null, From 82ea94022752e58df00bc9aaaf885aaa68ce252d Mon Sep 17 00:00:00 2001 From: Ofer Shaal Date: Thu, 21 May 2020 04:10:14 -0400 Subject: [PATCH 3/3] Remove an unused use statement --- packages/better-php-doc-parser/src/Printer/PhpDocInfoPrinter.php | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/better-php-doc-parser/src/Printer/PhpDocInfoPrinter.php b/packages/better-php-doc-parser/src/Printer/PhpDocInfoPrinter.php index 5b4a2ab15318..770802256ad1 100644 --- a/packages/better-php-doc-parser/src/Printer/PhpDocInfoPrinter.php +++ b/packages/better-php-doc-parser/src/Printer/PhpDocInfoPrinter.php @@ -6,7 +6,6 @@ use Nette\Utils\Strings; use PHPStan\PhpDocParser\Ast\PhpDoc\GenericTagValueNode; -use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocNode; use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocTagNode; use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocTextNode; use PHPStan\PhpDocParser\Lexer\Lexer;