Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about OpenSSL support to README #390

Merged
merged 1 commit into from Jan 4, 2019
Merged

Add note about OpenSSL support to README #390

merged 1 commit into from Jan 4, 2019

Conversation

aaron-junot
Copy link

This makes the README explicit that problems may be experienced when attempting to use an old, unsupported version of OpenSSL.

@aaron-junot aaron-junot requested a review from bhelx January 2, 2019 18:48
README.md Outdated
@@ -22,7 +22,8 @@ section, there's a line that says something like:
libcurl/7.19.5 OpenSSL/1.0.1g zlib/1.2.3.3 libidn/1.15
```

Please ensure that your OpenSSL version supports TLS v1.2 or higher.
Please ensure that your OpenSSL version supports TLS v1.2 (or higher) and that it meets requirements for the [OpenSSL library](http://php.net/manual/en/openssl.requirements.php).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP is now calling these extensions so let's change this a bit to make it clear which requirements we're talking about:

meets PHP's requirements for the OpenSSL extension.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or "OpenSSL cryptography extension"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, done

@drewish drewish merged commit 5acd01f into master Jan 4, 2019
@drewish drewish deleted the openssl-note branch January 4, 2019 00:07
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants