Adds __str__ to Suberror #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhelx
force-pushed
the
add_str_to_suberror
branch
from
4fb2a9f
to
f3ae326
Compare
pakal
reviewed
Nov 2, 2017
tests/test_resources.py
Outdated
| @@ -932,6 +932,9 @@ def test_subscribe_multiple_errors(self): | |||
| sub_errs = err.errors['subscription.account.account_code'] | |||
| self.assertEqual(len(sub_errs), 2) | |||
| self.assertEqual(type(sub_errs[1]), recurly.errors.ValidationError.Suberror) | |||
| # make sure we aren't falling back to default Suberror string | |||
| # represenation | |||
pakal
reviewed
Nov 2, 2017
tests/test_resources.py
Outdated
| @@ -932,6 +932,9 @@ def test_subscribe_multiple_errors(self): | |||
| sub_errs = err.errors['subscription.account.account_code'] | |||
| self.assertEqual(len(sub_errs), 2) | |||
| self.assertEqual(type(sub_errs[1]), recurly.errors.ValidationError.Suberror) | |||
| # make sure we aren't falling back to default Suberror string | |||
| # represenation | |||
| self.assertFalse("Suberror" in str(err)) | |||
There was a problem hiding this comment.
Positive asserts (checking the presence of a string) or much more robust than non-presence checks, maybe add one or two ?
There was a problem hiding this comment.
python2 and 3 arrange the keys in a different order. I'll add something to sort them first so they are consistent.
bhelx
force-pushed
the
add_str_to_suberror
branch
from
f3ae326
to
a4108d5
Compare
|
@pakal thanks for the comments. I am now sorting errors by key so the string representation is the same in python2 and python3. |
bhelx
force-pushed
the
add_str_to_suberror
branch
from
a4108d5
to
b98e23c
Compare
Resolves #217
bhelx
force-pushed
the
add_str_to_suberror
branch
from
b98e23c
to
3f39ab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #217