Adds support for shipping address #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrissrogers
force-pushed
the
shipping-address
branch
from
3d03169
to
be1f8fc
Compare
- Adds pricing class support for shipping address - Adds attachment procedure for shipping address - Establlishes that shipping address holds precedence for billing address in tax calculations Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
chrissrogers
force-pushed
the
shipping-address
branch
from
be1f8fc
to
8fe9d05
Compare
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
chrissrogers
commented
Oct 7, 2016
| @@ -93,7 +95,8 @@ Calculations.prototype.tax = function (done) { | |||
| this.price.now.tax = 0; | |||
| this.price.next.tax = 0; | |||
|
|
|||
| var taxInfo = merge({}, this.items.address); | |||
| const address = this.items.shipping_address || this.items.address; | |||
There was a problem hiding this comment.
This line determines address precedence. We calculate tax from shipping address first, then address if none is present
|
👍 |
snodgrass23
approved these changes
Oct 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pricing API updates
New pricing elements