Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP: Search for Community using elasticsearch #222
Conversation
surenm
and others
added some commits
Sep 10, 2014
zachallaun
reviewed
Sep 15, 2014
| @@ -1,2 +1,3 @@ | |||
| web: bin/puma -C config/puma.rb | |||
| worker: bin/rake jobs:work | |||
| elastisearch: elasticsearch | |||
This comment has been minimized.
This comment has been minimized.
zachallaun
reviewed
Sep 15, 2014
| margin-top: 10px; | ||
| font-size: 12px; | ||
| font-style: italic; | ||
| } |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@madhuvishy @surenm (@davidbalbert, I'd love you opinion as well) I'd love to start thinking about our query syntax a bit more. The Elasticsearch query DSL is quite extensive, and it would be cool to take advantage of more of it. In particular, I'd love to support narrowing queries based on subforums, thread titles, and post authors. Proposed query syntax (the email formatting of this might suck – look at it on GitHub for a pretty table):
The basic idea of the above is Another thing to consider is which part of our code should know about this mini-query language: the client or the server? Should the client be sending the server the string
or should it parse the query and send a data structure
I think we should go with the second option and do the parsing on the client. The client is going to want to know the syntax anyways so that it can help users make correct queries. But I don't have strong opinions about this yet. |
This comment has been minimized.
This comment has been minimized.
|
On searching with facets: This is definitely the next thing we wanted to work on. We thought we could put the DSL construction logic on the server side, but it does make sense that the client already knows for auto completion. |
This comment has been minimized.
This comment has been minimized.
|
+1 on using query DSL stuff and it was part of the plan to do this first before going to intent discovery. Like @madhuvishy said we had originally intended to do a dumb client against a search server/autocomplete endpoint which takes care of all intent discovery but the client side approach could be appropriate for community since a lot of action happens client side. I don't know which is a better method either but from my previous experiences I have always constructed the DSL on server side with varying levels of intelligence on the client side. |
surenm
and others
added some commits
Sep 22, 2014
davidbalbert
added some commits
Nov 11, 2014
davidbalbert
reviewed
Nov 11, 2014
|
|
||
|
|
||
| (defcomponent search-bar [app owner] | ||
| (display-name [_] "Autocomplete") |
This comment has been minimized.
This comment has been minimized.
davidbalbert
added some commits
Nov 11, 2014
This comment has been minimized.
This comment has been minimized.
|
Style bug: In Firefox, the server error box looks weird. Edit: Fixed. -Zach |
davidbalbert
reviewed
Nov 12, 2014
| :query "foo bar baz"}) | ||
| ;; => | ||
| "/api/search?q=foo bar baz&filters[author]=Zach Allaun" | ||
|
|
This comment has been minimized.
This comment has been minimized.
davidbalbert
Nov 12, 2014
Member
This looks like it was scratch, right? I think we should get rid of it.
davidbalbert
and others
added some commits
Nov 12, 2014
zachallaun
force-pushed the
surenm:search
branch
from
4967776
to
c8a915a
Nov 12, 2014
davidbalbert
added some commits
Nov 12, 2014
This comment has been minimized.
This comment has been minimized.
|
Ok, this is good to go. We're deploying :) |
surenm commentedSep 15, 2014
First cuts for search feature for Community