Bug 2132270: util: make inode metrics optional in FilesystemNodeGetVolumeStats()

[nixpanic]

CephFS does not have a concept of "free inodes", inodes get allocated on-demand in the filesystem.

This confuses alerting managers that expect a (high) number of free inodes, and warnings get produced if the number of free inodes is not high enough. This causes alerts to always get reported for CephFS.

To prevent the false-positive alerts from happening, the NodeGetVolumeStats procedure for CephFS (and CephNFS) will not contain inodes in the reply anymore.

I hereby confirm that:

• this change is in the upstream project (util: make inode metrics optional in FilesystemNodeGetVolumeStats() ceph/ceph-csi#3407)
• this change is in the devel branch of this project (Sync the upstream changes from ceph/ceph-csi:devel into the devel branch #138)
• branches for higher versions of the project have this change merged
• this PR is not downstream-only, if that was the case, I would have
  explained its need very clearly

[openshift-ci]

@nixpanic: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[Bug 2128263] util: make inode metrics optional in FilesystemNodeGetVolumeStats()

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nixpanic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nixpanic]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@nixpanic: This pull request references Bugzilla bug 2128263, which is invalid:

• expected the bug to target the "ODF 4.12.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2128263: util: make inode metrics optional in FilesystemNodeGetVolumeStats()

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nixpanic]

/bugzilla refresh

[openshift-ci]

@nixpanic: This pull request references Bugzilla bug 2128263, which is invalid:

• expected the bug to target the "ODF 4.12.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@nixpanic: This pull request references Bugzilla bug 2132270, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (ODF 4.12.0) matches configured target release for branch (ODF 4.12.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

Bug 2132270: util: make inode metrics optional in FilesystemNodeGetVolumeStats()

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@nixpanic: This pull request references Bugzilla bug 2132270, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (ODF 4.12.0) matches configured target release for branch (ODF 4.12.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

Bug 2132270: util: make inode metrics optional in FilesystemNodeGetVolumeStats()

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nixpanic]

now attached to the right bug.

/lgtm

[openshift-ci]

@nixpanic: you cannot LGTM your own PR.

In response to this:

now attached to the right bug.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nixpanic]

/assign Madhu-1

[Madhu-1]

/lgtm

[openshift-ci]

@nixpanic: All pull requests linked via external trackers have merged:

• red-hat-storage/ceph-csi#138
• red-hat-storage/ceph-csi#139

Bugzilla bug 2132270 has been moved to the MODIFIED state.

In response to this:

Bug 2132270: util: make inode metrics optional in FilesystemNodeGetVolumeStats()

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jmolmo]

/cherry-pick release-4.11

[openshift-cherrypick-robot]

@jmolmo: #139 failed to apply on top of branch "release-4.11":

Applying: util: make inode metrics optional in FilesystemNodeGetVolumeStats()
Using index info to reconstruct a base tree...
M	internal/cephfs/nodeserver.go
M	internal/csi-common/utils.go
M	internal/csi-common/utils_test.go
A	internal/nfs/nodeserver/nodeserver.go
M	internal/rbd/nodeserver.go
Falling back to patching base and 3-way merge...
Auto-merging internal/rbd/nodeserver.go
CONFLICT (content): Merge conflict in internal/rbd/nodeserver.go
CONFLICT (modify/delete): internal/nfs/nodeserver/nodeserver.go deleted in HEAD and modified in util: make inode metrics optional in FilesystemNodeGetVolumeStats(). Version util: make inode metrics optional in FilesystemNodeGetVolumeStats() of internal/nfs/nodeserver/nodeserver.go left in tree.
Auto-merging internal/csi-common/utils_test.go
CONFLICT (content): Merge conflict in internal/csi-common/utils_test.go
Auto-merging internal/csi-common/utils.go
CONFLICT (content): Merge conflict in internal/csi-common/utils.go
Auto-merging internal/cephfs/nodeserver.go
CONFLICT (content): Merge conflict in internal/cephfs/nodeserver.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 util: make inode metrics optional in FilesystemNodeGetVolumeStats()
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.