Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2233028: rebase: bump k8s.io dependencies to v0.26.7 #180

Conversation

karthik-us
Copy link
Member

Bumping the k8s.io dependencies to v0.26.7. The main intention is to update the client-go library dependency for kube 1.27+, where aggregated discovery is enabled. With client-go lower than v0.26.4 in some cases it is possible that the discovery response comes with the malformed response with nil GVK leading to Crash Loop Back Off state.

Upstream kubernetes issue:
kubernetes/kubernetes#116603
(cherry picked from commit 68bf88a)

Bumping the k8s.io dependencies to v0.26.7. The main intention
is to update the client-go library dependency for kube 1.27+,
where aggregated discovery is enabled. With client-go lower than
v0.26.4 in some cases it is possible that the discovery response
comes with the malformed response with nil GVK leading to Crash
Loop Back Off state.

Upstream kubernetes issue:
kubernetes/kubernetes#116603
(cherry picked from commit 68bf88a)

Signed-off-by: karthik-us <ksubrahm@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Aug 21, 2023

@karthik-us: This pull request references Bugzilla bug 2233028, which is invalid:

  • expected the bug to target the "ODF 4.13.2" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2233028: rebase: bump k8s.io dependencies to v0.26.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nixpanic
Copy link
Member

@karthik-us is this part of the release-14 and devel branches already?

@karthik-us
Copy link
Member Author

karthik-us commented Aug 21, 2023

@karthik-us is this part of the release-14 and devel branches already?

Yes, both devel and 4.14 are using k8s.io versions 0.27+ and 4.13 is using the older problematic version.

Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Code looks good label Aug 21, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karthik-us, nixpanic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Its a good idea label Aug 21, 2023
@openshift-bot
Copy link

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link

openshift-ci bot commented Aug 22, 2023

@openshift-bot: This pull request references Bugzilla bug 2233028, which is invalid:

  • expected the bug to target the "ODF 4.13.2" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Madhu-1
Copy link
Member

Madhu-1 commented Aug 22, 2023

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Aug 22, 2023

@Madhu-1: This pull request references Bugzilla bug 2233028, which is invalid:

  • expected the bug to target the "ODF 4.13.2" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2023

@openshift-bot: This pull request references Bugzilla bug 2233028, which is invalid:

  • expected the bug to target the "ODF 4.13.2" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

@openshift-bot: This pull request references Bugzilla bug 2233028, which is invalid:

  • expected the bug to target the "ODF 4.13.2" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nixpanic
Copy link
Member

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

@nixpanic: This pull request references Bugzilla bug 2233028, which is invalid:

  • expected the bug to target the "ODF 4.13.2" release, but it targets "ODF 4.13.3" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nixpanic
Copy link
Member

openshift/release#42649 has been merged, maybe it takes a little longer to get applied.... Need to retry the /bugzilla refresh a little later again.

@Madhu-1
Copy link
Member

Madhu-1 commented Aug 24, 2023

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

@Madhu-1: This pull request references Bugzilla bug 2233028, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.13.3) matches configured target release for branch (ODF 4.13.3)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@Madhu-1: This pull request references Bugzilla bug 2233028, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.13.3) matches configured target release for branch (ODF 4.13.3)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit c70bf62 into red-hat-storage:release-4.13 Aug 24, 2023
7 of 10 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

@karthik-us: All pull requests linked via external trackers have merged:

Bugzilla bug 2233028 has been moved to the MODIFIED state.

In response to this:

Bug 2233028: rebase: bump k8s.io dependencies to v0.26.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karthik-us karthik-us deleted the bump-client-go-4.13 branch August 25, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants