Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2053156: cephfs: dont set explicit permissions on the volume #79

Merged

Conversation

agarwal-mudit
Copy link
Member

At present we are node staging with worldwide permissions which is
not correct. We should allow the CO to take care of it and make
the decision. This commit also remove fuseMountOptions and
KernelMountOptions as they are no longer needed

Signed-off-by: Humble Chirammal hchiramm@redhat.com
(cherry picked from commit 8f6a7da)

At present we are node staging with worldwide permissions which is
not correct. We should allow the CO to take care of it and make
the decision. This commit also remove `fuseMountOptions` and
`KernelMountOptions` as they are no longer needed

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
(cherry picked from commit 8f6a7da)
@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2022

@agarwal-mudit: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

cephfs: dont set explicit permissions on the volume

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Its a good idea label Feb 14, 2022
@agarwal-mudit agarwal-mudit changed the title cephfs: dont set explicit permissions on the volume Bug 2053156: cephfs: dont set explicit permissions on the volume Feb 14, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2022

@agarwal-mudit: This pull request references Bugzilla bug 2053156, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.10.0) matches configured target release for branch (ODF 4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @ebenahar

In response to this:

Bug 2053156: cephfs: dont set explicit permissions on the volume

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@humblec
Copy link

humblec commented Feb 14, 2022

Cc @nixpanic @Madhu-1

@Madhu-1
Copy link
Member

Madhu-1 commented Feb 14, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Code looks good label Feb 14, 2022
@openshift-merge-robot openshift-merge-robot merged commit 0c1de34 into red-hat-storage:release-4.10 Feb 14, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2022

@agarwal-mudit: All pull requests linked via external trackers have merged:

Bugzilla bug 2053156 has been moved to the MODIFIED state.

In response to this:

Bug 2053156: cephfs: dont set explicit permissions on the volume

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agarwal-mudit agarwal-mudit deleted the bz2053156 branch February 14, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants