Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 2043034: use a unique label for csi-addons resources #29

Merged

Conversation

Madhu-1
Copy link
Member

@Madhu-1 Madhu-1 commented Feb 28, 2022

csi-addon operator is using the default label and labelSelector provided by operator-sdk:control-plane:
controller-manager for its resources, this is a generic label and it can cause problems when multiple resources uses same labels changing the label to unique one.

backport of #28

Signed-off-by: Madhu Rajanna madhupr007@gmail.com

Manually backporting as cherry-pick failed at #28 (comment)

csi-addon operator is using the default label and
labelSelector provided by operator-sdk:control-plane:
controller-manager
for its resources, this is a generic label and it can
cause problems when multiple resources uses same labels
changing the label to unique one.

backport of csi-addons#28

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@openshift-ci
Copy link

openshift-ci bot commented Feb 28, 2022

@Madhu-1: This pull request references Bugzilla bug 2043034, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.10.0) matches configured target release for branch (ODF 4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (musoni@redhat.com), skipping review request.

In response to this:

BUG 2043034: use a unique label for csi-addons resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Madhu-1
Copy link
Member Author

Madhu-1 commented Feb 28, 2022

/assign @nixpanic

Copy link
Member

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Feb 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhu-1, Rakshith-R

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 961ad40 into red-hat-storage:release-4.10 Feb 28, 2022
8 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Feb 28, 2022

@Madhu-1: All pull requests linked via external trackers have merged:

Bugzilla bug 2043034 has been moved to the MODIFIED state.

In response to this:

BUG 2043034: use a unique label for csi-addons resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants