Bug 2144527: replication: reduce RPC calls when VR state is primary #73
Conversation
Avoid extra RPC calls as request will be requested again for updating the LastSyncTime in the status. The image need to be promoted only one time not always during the reconcile. fixes: csi-addons#250 Co-authored-by: Madhu Rajanna <madhupr007@gmail.com> Signed-off-by: yati1998 <ypadia@redhat.com> (cherry picked from commit 0b3d35e)
|
@yati1998: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
yati1998
changed the title
|
@yati1998: This pull request references Bugzilla bug 2144527, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @Madhu-1 |
|
CI failure reason #70 (comment) |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Madhu-1, yati1998 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override kind_depoy |
|
@Madhu-1: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override kind_deploy |
|
@Madhu-1: Overrode contexts on behalf of Madhu-1: kind_deploy In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-robot
merged commit d7b9ad1
into
red-hat-storage:release-4.12
|
@yati1998: All pull requests linked via external trackers have merged: Bugzilla bug 2144527 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Avoid extra RPC calls as request will be requested again for updating the LastSyncTime in the status. The image need to be promoted only one time not always during the reconcile.
fixes: csi-addons#250
Co-authored-by: Madhu Rajanna madhupr007@gmail.com
Signed-off-by: yati1998 ypadia@redhat.com
(cherry picked from commit 0b3d35e)