Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PrometheusRuleFailures alert test #4082

Merged
merged 2 commits into from Apr 2, 2021
Merged

Add PrometheusRuleFailures alert test #4082

merged 2 commits into from Apr 2, 2021

Conversation

fbalak
Copy link
Contributor

@fbalak fbalak commented Mar 31, 2021

@fbalak fbalak self-assigned this Mar 31, 2021
@fbalak fbalak requested a review from a team as a code owner March 31, 2021 14:59
@fbalak
add PrometheusRuleFailures alert test
19f2f39 
Signed-off-by: Filip Balak <fbalak@redhat.com>
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Mar 31, 2021
ocs-ci
ocs-ci reviewed Mar 31, 2021
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/monitoring/prometheus/test_alerting_works.py
Additional Test Params:
OCP VERSION: 4.7
OCS VERSION: 4.7

Job PASSED.

mbukatov
mbukatov previously approved these changes Mar 31, 2021
View reviewed changes
@fbalak fbalak added the Verified Mark when PR was verified and log provided label Apr 1, 2021
@fbalak
add bugzilla marker
e52da0e 
Signed-off-by: Filip Balak <fbalak@redhat.com>
@mbukatov mbukatov merged commit 4d15128 into red-hat-storage:master Apr 2, 2021
Gangadhar-ibm pushed a commit to Gangadhar-ibm/ocs-ci that referenced this pull request Jun 14, 2021
@fbalak @Gangadhar-ibm-lab
Add PrometheusRuleFailures alert test (red-hat-storage#4082)
6ee8493 
* add PrometheusRuleFailures alert test
* add bugzilla marker

Signed-off-by: Filip Balak <fbalak@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@mbukatov mbukatov mbukatov approved these changes

@PrasadDesala PrasadDesala PrasadDesala approved these changes

@shreekarSS shreekarSS Awaiting requested review from shreekarSS

Assignees

@fbalak fbalak

Labels
size/S PR that changes 10-29 lines Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tier1 alerting test case: there should be no PrometheusRuleFailures alerts
4 participants
@fbalak @mbukatov @PrasadDesala @ocs-ci