Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to enable huge pages #4461

Merged
merged 1 commit into from Jun 24, 2021
Merged

Add function to enable huge pages #4461

merged 1 commit into from Jun 24, 2021

Conversation

petr-balogh
Copy link
Member

Signed-off-by: Petr Balogh pbalogh@redhat.com

@petr-balogh petr-balogh requested a review from a team as a code owner June 23, 2021 12:44
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Jun 23, 2021
ocs-ci
ocs-ci reviewed Jun 23, 2021
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration: ocs_ci/templates/ocp-deployment/huge_pages.yaml
PR Test Suite: deployment
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.7
OCS VERSION: 4.7

Job FAILED (installation failed, tests not executed).

vavuthu
vavuthu reviewed Jun 24, 2021
View reviewed changes
ocs_ci/ocs/constants.py Outdated
@@ -68,9 +68,13 @@
ROOK_CSI_CEPHFS_DIR = os.path.join(ROOK_EXAMPLES_DIR, "csi", "cephfs")
CLEANUP_YAML = "cleanup.yaml.j2"
MANIFESTS_DIR = "manifests"


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove blank line here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes there were two empty lines between sections, sometime one, I deleted it on every place were we had 2 and we should now follow only one. Thanks

@vavuthu vavuthu added team/ecosystem Ecosystem team related issues/PRs Needs Deployment Testing Needs Deployment and Some Tier1 Testing labels Jun 24, 2021
vavuthu
vavuthu reviewed Jun 24, 2021
View reviewed changes
docs/usecases/enable_huge_pages.md Outdated
Comment on lines 3 to 10
If you need to enable Huge Pages please use this config file:

`ocs_ci/templates/ocp-deployment/huge_pages.yaml`

If you pass this file via --ocsci-conf, it will apply this file:

`ocs_ci/templates/ocp-deployment/huge_pages.yaml`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to enable huge pages using conf/ocsci/enable_huge_pages.yaml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, yep, I copied wrong file :( the same in verification

@vavuthu
Copy link
Contributor

vavuthu commented Jun 24, 2021

PR validation

Cluster Name:
Cluster Configuration: ocs_ci/templates/ocp-deployment/huge_pages.yaml
PR Test Suite: deployment
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.7
OCS VERSION: 4.7

Job FAILED (installation failed, tests not executed).

looks like you have passed wrong conf file

@petr-balogh
Add function to enable huge pages
368e75b 
Signed-off-by: Petr Balogh <pbalogh@redhat.com>
@petr-balogh petr-balogh added Verified Mark when PR was verified and log provided enhancement New feature or request and removed Needs Deployment Testing Needs Deployment and Some Tier1 Testing labels Jun 24, 2021
@petr-balogh
Copy link
Member Author

petr-balogh commented Jun 24, 2021 •
edited

Verified here:
https://ocs4-jenkins-csb-ocsqe.apps.ocp4.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/4056/console

$ oc debug node/ip-10-0-136-77.us-east-2.compute.internal
Creating debug namespace/openshift-debug-node-zfbkm ...
Starting pod/ip-10-0-136-77us-east-2computeinternal-debug ...
To use host binaries, run `chroot /host`
Pod IP: 10.0.136.77
If you don't see a command prompt, try pressing enter.
sh-4.4# chroot /host
sh-4.4# grep HugePages_ /proc/meminfo
HugePages_Total:      32
HugePages_Free:       32
HugePages_Rsvd:        0
HugePages_Surp:        0

@petr-balogh petr-balogh merged commit 8dcde9b into red-hat-storage:master Jun 24, 2021
ocs-ci
ocs-ci reviewed Jun 24, 2021
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration: ocs_ci/templates/ocp-deployment/huge_pages.yaml
PR Test Suite: deployment
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.7
OCS VERSION: 4.7

Job FAILED (installation failed, tests not executed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@dahorak dahorak dahorak approved these changes

@vavuthu vavuthu vavuthu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size/M PR that changes 30-99 lines team/ecosystem Ecosystem team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@petr-balogh @vavuthu @dahorak @ocs-ci