Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applies huge pages and verifies cluster pods are running #5472

Merged
merged 9 commits into from Mar 3, 2022
Merged

Applies huge pages and verifies cluster pods are running #5472

merged 9 commits into from Mar 3, 2022

Conversation

parikshithb
Copy link
Contributor

Signed-off-by: Parikshith Byregowda pbyregow@redhat.com

@parikshithb
Applies huge pages and verifies cluster pods are running
5f5b700 
Signed-off-by: Parikshith Byregowda <pbyregow@redhat.com>
@parikshithb parikshithb added Needs Testing Run tests and provide logs link team/e2e E2E team related issues/PRs labels Feb 15, 2022
@parikshithb parikshithb self-assigned this Feb 15, 2022
@parikshithb parikshithb requested review from a team as code owners February 15, 2022 06:33
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Feb 15, 2022
@parikshithb
condition
60ff437 
Signed-off-by: Parikshith Byregowda <pbyregow@redhat.com>
@parikshithb
polarion id
69862e4 
Signed-off-by: Parikshith Byregowda <pbyregow@redhat.com>
@parikshithb
Sanity
7322c40 
Signed-off-by: Parikshith Byregowda <pbyregow@redhat.com>
ocs-ci
ocs-ci reviewed Feb 16, 2022
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: dnd-pbyregow-aw
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/z_cluster/test_hugepages.py
Additional Test Params:
OCP VERSION: 4.10
OCS VERSION: 4.10
tested against branch: master

Job FAILED (installation failed, tests not executed).

ocs-ci
ocs-ci reviewed Feb 16, 2022
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: dnd-pbyregow-aw
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/manage/z_cluster/test_hugepages.py
Additional Test Params:
OCP VERSION: 4.10
OCS VERSION: 4.10
tested against branch: master

Job PASSED.

@parikshithb parikshithb added Verified Mark when PR was verified and log provided and removed Needs Testing Run tests and provide logs link labels Feb 16, 2022
PrasadDesala
PrasadDesala reviewed Feb 17, 2022
View reviewed changes
tests/manage/z_cluster/test_hugepages.py Show resolved Hide resolved
tests/manage/z_cluster/test_hugepages.py Outdated


@tier2
@skipif_external_mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can configure hugepages on openshift nodes and then are consumed by apps. I think it should valid even for external mode, any reason for skipping the test to run on external mode?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, removed skip

tests/manage/z_cluster/test_hugepages.py Outdated
@ignore_leftovers
class TestHugePages(E2ETest):
"""
Enable huge pages post cluster deployment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it clear that in this test, huge pages is enabled post ODF installation to avoid confusion as huge pages can also be enabled immediate after ocp cluster deployment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

tests/manage/z_cluster/test_hugepages.py Show resolved Hide resolved
tests/manage/z_cluster/test_hugepages.py Show resolved Hide resolved
@parikshithb
fixes
586b7f8 
Signed-off-by: Parikshith Byregowda <pbyregow@redhat.com>
@parikshithb
Merge branch 'master' into hp_with_odf
c345827
@parikshithb
conflicts
c625022 
Signed-off-by: Parikshith Byregowda <pbyregow@redhat.com>
ocs-ci
ocs-ci reviewed Feb 28, 2022
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: pbyregow-feb
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/manage/z_cluster/test_hugepages.py
Additional Test Params:
OCP VERSION: 4.10
OCS VERSION: 4.10
tested against branch: master

Job UNSTABLE (some or all tests failed).

@parikshithb
wait for ceph
d180ade 
Signed-off-by: Parikshith Byregowda <pbyregow@redhat.com>
ocs-ci
ocs-ci reviewed Feb 28, 2022
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: pbyregow-feb
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/manage/z_cluster/test_hugepages.py
Additional Test Params:
OCP VERSION: 4.10
OCS VERSION: 4.10
tested against branch: master

Job UNSTABLE (some or all tests failed).

@parikshithb
ceph_health
6202a4e 
Signed-off-by: Parikshith Byregowda <pbyregow@redhat.com>
ocs-ci
ocs-ci reviewed Feb 28, 2022
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: pbyregow-feb
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/manage/z_cluster/test_hugepages.py
Additional Test Params:
OCP VERSION: 4.10
OCS VERSION: 4.10
tested against branch: master

Job PASSED.

@PrasadDesala PrasadDesala merged commit 5ee7a2f into red-hat-storage:master Mar 3, 2022
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@PrasadDesala PrasadDesala PrasadDesala approved these changes

@prsurve prsurve prsurve approved these changes

@Akarsha-rai Akarsha-rai Awaiting requested review from Akarsha-rai

Assignees

@parikshithb parikshithb

Labels
size/L PR that changes 100-499 lines team/e2e E2E team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@parikshithb @PrasadDesala @prsurve @ocs-ci