Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RBD ReclaimSpaceJob and ReclaimSpaceCronJob #5677

Merged
merged 3 commits into from Jun 17, 2022
Merged

RBD ReclaimSpaceJob and ReclaimSpaceCronJob #5677

merged 3 commits into from Jun 17, 2022

Conversation

keemano
Copy link
Contributor

@keemano keemano commented Apr 5, 2022

Test cases covered: -

  1. Reclaiming the space using ReclaimSpaceCronJob
  2. Reclaiming the space using ReclaimSpaceJob when
    -> No space is available to claim
    -> No volume is mounted

@keemano keemano requested review from a team as code owners April 5, 2022 08:52
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Apr 5, 2022
@keemano keemano added team/manage Manage team related issues/PRs Test Case A test case PR labels Apr 5, 2022
@keesturam keesturam requested a review from jilju April 11, 2022 05:20
jilju
jilju previously approved these changes May 26, 2022
View reviewed changes
ocs-ci
ocs-ci reviewed May 27, 2022
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: /tests/manage/pv_services/space_reclaim/test_rbd_reclaimspace_cronjob.py /tests/manage/pv_services/space_reclaim/test_rbd_space_reclaim.py
Additional Test Params:
OCP VERSION: 4.10-ga
OCS VERSION: 4.10
tested against branch: master

Job FAILED (installation failed, tests not executed).

ocs-ci
ocs-ci reviewed May 27, 2022
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/pv_services/space_reclaim/test_rbd_reclaimspace_cronjob.py tests/manage/pv_services/space_reclaim/test_rbd_space_reclaim.py
Additional Test Params:
OCP VERSION: 4.10-ga
OCS VERSION: 4.10
tested against branch: master

Job FAILED (installation failed, tests not executed).

ypersky1980
ypersky1980 previously approved these changes May 29, 2022
View reviewed changes
Copy link
Contributor

@ypersky1980 ypersky1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ocs-ci
ocs-ci reviewed Jun 6, 2022
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/pv_services/space_reclaim/test_rbd_reclaimspace_cronjob.py tests/manage/pv_services/space_reclaim/test_rbd_space_reclaim.py
Additional Test Params:
OCP VERSION: 4.10-ga
OCS VERSION: 4.10
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci
ocs-ci reviewed Jun 8, 2022
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/pv_services/space_reclaim/test_rbd_reclaimspace_cronjob.py tests/manage/pv_services/space_reclaim/test_rbd_space_reclaim.py
Additional Test Params:
OCP VERSION: 4.10-ga
OCS VERSION: 4.10
tested against branch: master

Job FAILED (installation failed, tests not executed).

ocs-ci
ocs-ci reviewed Jun 9, 2022
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/pv_services/space_reclaim/test_rbd_reclaimspace_cronjob.py tests/manage/pv_services/space_reclaim/test_rbd_space_reclaim.py
Additional Test Params:
OCP VERSION: 4.10-ga
OCS VERSION: 4.10
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci
ocs-ci reviewed Jun 9, 2022
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/pv_services/space_reclaim/test_rbd_space_reclaim.py::TestRbdSpaceReclaim::test_rbd_space_reclaim
Additional Test Params:
OCP VERSION: 4.10-ga
OCS VERSION: 4.10
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci
ocs-ci reviewed Jun 16, 2022
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/pv_services/space_reclaim/test_rbd_reclaimspace_cronjob.py tests/manage/pv_services/space_reclaim/test_rbd_space_reclaim.py::TestRbdSpaceReclaim::test_rbd_space_reclaim_no_space tests/manage/pv_services/space_reclaim/test_rbd_space_reclaim.py::TestRbdSpaceReclaim::test_no_volume_mounted
Additional Test Params:
OCP VERSION: 4.10-ga
OCS VERSION: 4.10
tested against branch: master

Job PASSED.

@PrasadDesala PrasadDesala merged commit f7c2e6a into red-hat-storage:master Jun 17, 2022
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@ramkiperiy ramkiperiy ramkiperiy approved these changes

@PrasadDesala PrasadDesala PrasadDesala approved these changes

@jilju jilju jilju approved these changes

@ypersky1980 ypersky1980 ypersky1980 left review comments

@keesturam keesturam Awaiting requested review from keesturam

Assignees
No one assigned
Labels
size/L PR that changes 100-499 lines team/manage Manage team related issues/PRs Test Case A test case PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@keemano @ramkiperiy @PrasadDesala @jilju @ocs-ci @ypersky1980