Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FORCE_OSD_REMOVAL flag on ocs-osd-removal-job #6114

Merged
merged 9 commits into from Jul 25, 2022

Conversation

OdedViner
Copy link
Contributor

@OdedViner OdedViner commented Jul 3, 2022

https://bugzilla.redhat.com/show_bug.cgi?id=2057359#c4
https://bugzilla.redhat.com/show_bug.cgi?id=2026007

Test Path:
tests/manage/z_cluster/nodes/test_disk_failures.py::TestDiskFailures::test_recovery_from_volume_deletion

Signed-off-by: Oded Viner <oviner@redhat.com>
Signed-off-by: Oded Viner <oviner@redhat.com>
Signed-off-by: Oded Viner <oviner@redhat.com>
Signed-off-by: Oded Viner <oviner@redhat.com>
Signed-off-by: Oded Viner <oviner@redhat.com>
Signed-off-by: OdedViner <oviner@redhat.com>
@OdedViner OdedViner requested a review from a team as a code owner July 3, 2022 11:53
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Jul 3, 2022
@OdedViner OdedViner changed the title Pr 5551 Added FORCE_OSD_REMOVAL flag on ocs-osd-removal-job Jul 3, 2022
Signed-off-by: OdedViner <oviner@redhat.com>
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/manage/z_cluster/nodes/test_disk_failures.py::TestDiskFailures::test_recovery_from_volume_deletion
Additional Test Params:
OCP VERSION: 4.11
OCS VERSION: 4.11
tested against branch: master

Job FAILED (installation failed, tests not executed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/manage/z_cluster/nodes/test_disk_failures.py::TestDiskFailures::test_recovery_from_volume_deletion
Additional Test Params:
OCP VERSION: 4.11
OCS VERSION: 4.11
tested against branch: master

Job PASSED.

@OdedViner OdedViner added the Verified Mark when PR was verified and log provided label Jul 7, 2022
Comment on lines 157 to 161
else:
expected_old_pv_statuses = [
constants.STATUS_RELEASED,
constants.STATUS_FAILED,
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non lso expected_old_pv_statuses check is removed here, any reason?

Comment on lines 157 to 162
assert (
osd_pv.ocp.get_resource_status(osd_pv_name) in expected_old_pv_statuses
), logger.warning(
f"The old PV '{osd_pv_name}' is not in "
f"the expected statuses: {expected_old_pv_statuses}"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the expected_old_pv_statuses same for all ocp version > 4.6?

Signed-off-by: OdedViner <oviner@redhat.com>
Signed-off-by: OdedViner <oviner@redhat.com>
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/manage/z_cluster/nodes/test_disk_failures.py::TestDiskFailures::test_recovery_from_volume_deletion
Additional Test Params:
OCP VERSION: 4.11
OCS VERSION: 4.11
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vmfs_lso_vmdk_3m_3w.yaml
PR Test Suite: tier4a
PR Test Path: tests/manage/z_cluster/nodes/test_disk_failures.py::TestDiskFailures::test_recovery_from_volume_deletion
Additional Test Params:
OCP VERSION: 4.11
OCS VERSION: 4.11
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/manage/z_cluster/nodes/test_disk_failures.py::TestDiskFailures::test_recovery_from_volume_deletion
Additional Test Params:
OCP VERSION: 4.11
OCS VERSION: 4.11
tested against branch: master

Job UNSTABLE (some or all tests failed).

@PrasadDesala PrasadDesala added team/e2e E2E team related issues/PRs Customer defects Defects automated aspart of GSS closed loop labels Jul 13, 2022
@ebenahar ebenahar merged commit 39e340e into red-hat-storage:master Jul 25, 2022
5 of 6 checks passed
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vmfs_lso_vmdk_3m_3w.yaml
PR Test Suite: tier4a
PR Test Path: tests/manage/z_cluster/nodes/test_disk_failures.py::TestDiskFailures::test_recovery_from_volume_deletion
Additional Test Params:
OCP VERSION: 4.11
OCS VERSION: 4.11
tested against branch: master

Job FAILED (installation failed, tests not executed).

@am-agrawa
Copy link
Contributor

@OdedViner Do we have any PR validation job which passes for this particular test case with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer defects Defects automated aspart of GSS closed loop size/M PR that changes 30-99 lines team/e2e E2E team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants