New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added FORCE_OSD_REMOVAL flag on ocs-osd-removal-job #6114
Conversation
Signed-off-by: Oded Viner <oviner@redhat.com>
Signed-off-by: Oded Viner <oviner@redhat.com>
Signed-off-by: Oded Viner <oviner@redhat.com>
Signed-off-by: Oded Viner <oviner@redhat.com>
Signed-off-by: Oded Viner <oviner@redhat.com>
Signed-off-by: OdedViner <oviner@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/manage/z_cluster/nodes/test_disk_failures.py::TestDiskFailures::test_recovery_from_volume_deletion
Additional Test Params:
OCP VERSION: 4.11
OCS VERSION: 4.11
tested against branch: master
Job FAILED (installation failed, tests not executed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/manage/z_cluster/nodes/test_disk_failures.py::TestDiskFailures::test_recovery_from_volume_deletion
Additional Test Params:
OCP VERSION: 4.11
OCS VERSION: 4.11
tested against branch: master
ocs_ci/ocs/osd_operations.py
Outdated
| else: | ||
| expected_old_pv_statuses = [ | ||
| constants.STATUS_RELEASED, | ||
| constants.STATUS_FAILED, | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non lso expected_old_pv_statuses check is removed here, any reason?
ocs_ci/ocs/osd_operations.py
Outdated
| assert ( | ||
| osd_pv.ocp.get_resource_status(osd_pv_name) in expected_old_pv_statuses | ||
| ), logger.warning( | ||
| f"The old PV '{osd_pv_name}' is not in " | ||
| f"the expected statuses: {expected_old_pv_statuses}" | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the expected_old_pv_statuses same for all ocp version > 4.6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/manage/z_cluster/nodes/test_disk_failures.py::TestDiskFailures::test_recovery_from_volume_deletion
Additional Test Params:
OCP VERSION: 4.11
OCS VERSION: 4.11
tested against branch: master
Job UNSTABLE (some or all tests failed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vmfs_lso_vmdk_3m_3w.yaml
PR Test Suite: tier4a
PR Test Path: tests/manage/z_cluster/nodes/test_disk_failures.py::TestDiskFailures::test_recovery_from_volume_deletion
Additional Test Params:
OCP VERSION: 4.11
OCS VERSION: 4.11
tested against branch: master
Job UNSTABLE (some or all tests failed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/manage/z_cluster/nodes/test_disk_failures.py::TestDiskFailures::test_recovery_from_volume_deletion
Additional Test Params:
OCP VERSION: 4.11
OCS VERSION: 4.11
tested against branch: master
Job UNSTABLE (some or all tests failed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vmfs_lso_vmdk_3m_3w.yaml
PR Test Suite: tier4a
PR Test Path: tests/manage/z_cluster/nodes/test_disk_failures.py::TestDiskFailures::test_recovery_from_volume_deletion
Additional Test Params:
OCP VERSION: 4.11
OCS VERSION: 4.11
tested against branch: master
Job FAILED (installation failed, tests not executed).
|
@OdedViner Do we have any PR validation job which passes for this particular test case with this fix? |
https://bugzilla.redhat.com/show_bug.cgi?id=2057359#c4
https://bugzilla.redhat.com/show_bug.cgi?id=2026007
Test Path:
tests/manage/z_cluster/nodes/test_disk_failures.py::TestDiskFailures::test_recovery_from_volume_deletion