Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1978663: [release-4.8] must-gather: remove the standard pod template #1256

Merged
merged 2 commits into from Jul 5, 2021
Merged

Bug 1978663: [release-4.8] must-gather: remove the standard pod template #1256

merged 2 commits into from Jul 5, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1255

/assign agarwal-mudit

@agarwal-mudit
must-gather: remove the standard pod template
cb4acb7 
We don't need two pod templates now, removing the standard
pod template and the code around it.

Signed-off-by: Mudit Agarwal <muagarwa@redhat.com>
@agarwal-mudit
must-gather: rename latest pod template
2115712 
Signed-off-by: Mudit Agarwal <muagarwa@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 2, 2021
Merged
@openshift-ci openshift-ci bot requested review from crombus and rajatsing July 2, 2021 17:16
@agarwal-mudit
Copy link
Member

/retitle Bug 1978663: [release-4.8] must-gather: remove the standard pod template

@openshift-ci openshift-ci bot changed the title [release-4.8] must-gather: remove the standard pod template Bug 1978663: [release-4.8] must-gather: remove the standard pod template Jul 2, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jul 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1978663, which is invalid:

  • expected the bug to target the "OCS 4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1978663: [release-4.8] must-gather: remove the standard pod template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agarwal-mudit
Copy link
Member

/hold
BZ is not acked

@openshift-ci openshift-ci bot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 2, 2021
@agarwal-mudit
Copy link
Member

/retest

@agarwal-mudit
Copy link
Member

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2021

@agarwal-mudit: This pull request references Bugzilla bug 1978663, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (OCS 4.8.0) matches configured target release for branch (OCS 4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 5, 2021
@agarwal-mudit
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2021
@agarwal-mudit
Copy link
Member

/override ci/prow/red-hat-storage-ocs-ci-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2021

@agarwal-mudit: Overrode contexts on behalf of agarwal-mudit: ci/prow/red-hat-storage-ocs-ci-e2e-aws

In response to this:

/override ci/prow/red-hat-storage-ocs-ci-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

umangachapagain
umangachapagain approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@umangachapagain umangachapagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2021
@openshift-merge-robot openshift-merge-robot merged commit fcc343a into red-hat-storage:release-4.8 Jul 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1978663 has been moved to the MODIFIED state.

In response to this:

Bug 1978663: [release-4.8] must-gather: remove the standard pod template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umangachapagain umangachapagain umangachapagain approved these changes

@crombus crombus Awaiting requested review from crombus

@rajatsing rajatsing Awaiting requested review from rajatsing

Assignees

@umangachapagain umangachapagain

@agarwal-mudit agarwal-mudit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@openshift-cherrypick-robot @agarwal-mudit @umangachapagain @openshift-merge-robot