Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

must-gather: change file permission for gather_common_ceph_resources.… #1258

Merged
merged 2 commits into from Jul 6, 2021

Conversation

crombus
Copy link
Contributor

@crombus crombus commented Jul 5, 2021

…sh file

Signed-off-by: crombus pkundra@redhat.com

…sh file

Signed-off-by: crombus <pkundra@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2021
@crombus
Copy link
Contributor Author

crombus commented Jul 5, 2021

/hold until the testing is done.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2021
@crombus
Copy link
Contributor Author

crombus commented Jul 5, 2021

/hold until the testing is done.

@crombus
Copy link
Contributor Author

crombus commented Jul 6, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2021
remove the lOC which copying the logs from non-existing file
and remove the line which is deleting the non-existing file.

Signed-off-by: crombus <pkundra@redhat.com>
Copy link
Member

@agarwal-mudit agarwal-mudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit, rajatsing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 721fa42 into red-hat-storage:master Jul 6, 2021
@agarwal-mudit
Copy link
Member

/cherry-pick release-4.8

@openshift-cherrypick-robot

@agarwal-mudit: new pull request created: #1261

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants