Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1963207: [release-4.8] must-gather: change file permission for gather_common_ceph_resources.sh file #1261

Merged
merged 2 commits into from Jul 6, 2021
Merged

Bug 1963207: [release-4.8] must-gather: change file permission for gather_common_ceph_resources.sh file #1261

merged 2 commits into from Jul 6, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1258

/assign agarwal-mudit

@crombus
must-gather: change file permission for gather_common_ceph_resources.…
c4fa2ec 
…sh file

Signed-off-by: crombus <pkundra@redhat.com>
@crombus
must-gather: avoid deletion of non-existing file
68b5e5b 
remove the lOC which copying the logs from non-existing file
and remove the line which is deleting the non-existing file.

Signed-off-by: crombus <pkundra@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 6, 2021
Merged
@openshift-ci openshift-ci bot requested review from crombus and rajatsing July 6, 2021 13:44
@agarwal-mudit
Copy link
Member

/retitle Bug 1963207: [release-4.8] must-gather: change file permission for gather_common_ceph_resources.sh file

@openshift-ci openshift-ci bot changed the title [release-4.8] must-gather: change file permission for gather_common_ceph_resources.… Bug 1963207: [release-4.8] must-gather: change file permission for gather_common_ceph_resources.sh file Jul 6, 2021
@agarwal-mudit
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jul 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1963207, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (OCS 4.8.0) matches configured target release for branch (OCS 4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (tunguyen@redhat.com), skipping review request.

In response to this:

Bug 1963207: [release-4.8] must-gather: change file permission for gather_common_ceph_resources.sh file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit, rajatsing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agarwal-mudit
Copy link
Member

/retest

@agarwal-mudit
Copy link
Member

/override ci/prow/red-hat-storage-ocs-ci-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2021

@agarwal-mudit: Overrode contexts on behalf of agarwal-mudit: ci/prow/red-hat-storage-ocs-ci-e2e-aws

In response to this:

/override ci/prow/red-hat-storage-ocs-ci-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 9d74c6a into red-hat-storage:release-4.8 Jul 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1963207 has been moved to the MODIFIED state.

In response to this:

Bug 1963207: [release-4.8] must-gather: change file permission for gather_common_ceph_resources.sh file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajatsing rajatsing rajatsing approved these changes

@crombus crombus Awaiting requested review from crombus

Assignees

@agarwal-mudit agarwal-mudit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@openshift-cherrypick-robot @agarwal-mudit @rajatsing @openshift-merge-robot @crombus