Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add managedBy label only for mcg-standalone #1386

Merged
merged 1 commit into from Nov 8, 2021

Conversation

umangachapagain
Copy link
Contributor

@umangachapagain umangachapagain commented Oct 20, 2021

Adding managedBy label only when mcg is standalone. This is to prevent collision when mcg is deployed along with Ceph.

Signed-off-by: Umanga Chapagain chapagainumanga@gmail.com

Signed-off-by: Umanga Chapagain <chapagainumanga@gmail.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 20, 2021
@SanjalKatiyar
Copy link
Contributor

SanjalKatiyar commented Oct 20, 2021

Health Status query returns only ceph metric:
Screenshot from 2021-10-20 21-31-30

managedBy label is empty for NooBaa metric:
Screenshot from 2021-10-20 21-32-34

Dashboard only shows the status of ceph system:
Screenshot from 2021-10-20 21-31-37

@umangachapagain umangachapagain changed the title [WIP] add managedBy label only for mcg-standalone add managedBy label only for mcg-standalone Oct 21, 2021
@umangachapagain umangachapagain marked this pull request as ready for review October 21, 2021 07:36
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2021
@umangachapagain
Copy link
Contributor Author

/cherry-pick release-4.9

@openshift-cherrypick-robot

@umangachapagain: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SanjalKatiyar
Copy link
Contributor

/test red-hat-storage-ocs-ci-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2021

@umangachapagain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws 4a9943d link false /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jarrpa,umangachapagain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-cherrypick-robot

@umangachapagain: new pull request created: #1400

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@umangachapagain umangachapagain deleted the labels branch December 27, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants