Fix StorageCluster is in error state for few minutes after installing #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malayparida2000
force-pushed
the
cluster_phase
branch
from
696e380
to
504bcdc
Compare
|
/cc @iamniting |
iamniting
requested changes
Aug 30, 2022
malayparida2000
force-pushed
the
cluster_phase
branch
from
504bcdc
to
b5718f7
Compare
iamniting
requested changes
Aug 30, 2022
malayparida2000
force-pushed
the
cluster_phase
branch
from
b5718f7
to
f403fa5
Compare
|
/retest |
iamniting
requested changes
Sep 1, 2022
malayparida2000
force-pushed
the
cluster_phase
branch
from
f403fa5
to
18d1d55
Compare
iamniting
requested changes
Sep 1, 2022
malayparida2000
force-pushed
the
cluster_phase
branch
3 times, most recently
from
743977d
to
5a7e02f
Compare
While storageclasses are being created it's waiting till underlying resources like cephBlockPool, cephFilesystem & NFS are created. In this phase, we are returning an error which results in the phase of the storagecluster to be in Error, creating confusion for the user. So henceforth this particular error would be caught, A requeue Reconcile result would be given and the storagecluster would be marked as in the Progressing Phase. Signed-off-by: Malay Kumar Parida <mparida@redhat.com>
malayparida2000
force-pushed
the
cluster_phase
branch
from
5a7e02f
to
6a5c070
Compare
|
@agarwal-mudit need approve |
umangachapagain
approved these changes
Sep 1, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, malayparida2000, umangachapagain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: https://bugzilla.redhat.com/show_bug.cgi?id=2004027
Stop setting storagecluster to error phase just after creation