Limit OCS operator leaderElection & cache to operator namespace #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malayparida2000
force-pushed
the
memory_fix
branch
2 times, most recently
from
07349a7
to
c3741c7
Compare
malayparida2000
changed the title
Currently ocs-operator is relying on the default "AllNamespaces" cache in controller-runtime, which works by syncing all the Kubernetes resources in the cluster. This initial informer cache sync is so huge that it causes a sudden massive spike in the memory usage of the operator. This causes OOMKilled failures for the ocs-operator pods. So ocs-operator will now set the leaderElectionNamespace & the Manager cache to the namespace where the operator is deployed. This will ensure that the initial cache sync will only sync the resources in the namespace where the operator is deployed. Signed-off-by: Malay Kumar Parida <mparida@redhat.com>
malayparida2000
force-pushed
the
memory_fix
branch
from
c3741c7
to
d98bf7b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, malayparida2000 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ocs-operator is relying on the default "AllNamespaces" cache
in controller-runtime, which works by syncing all the Kubernetes
resources in the cluster. This initial informer cache sync is so huge
that it causes a sudden massive spike in the memory usage of the
operator. This causes OOMKilled failures for the ocs-operator pods.
So ocs-operator will now set the leaderElectionNamespace & the Manager
cache to the namespace where the operator is deployed. This will
ensure that the initial cache sync will only sync the resources in the
namespace where the operator is deployed.
Signed-off-by: Malay Kumar Parida mparida@redhat.com
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2126626