Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2174335:[release-4.12] update the labels while updating the servicemonitor and prometheusrules #1964

Merged
merged 2 commits into from Mar 22, 2023
Merged

Bug 2174335:[release-4.12] update the labels while updating the servicemonitor and prometheusrules #1964

merged 2 commits into from Mar 22, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1925

/assign iamniting

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 20, 2023
Merged
@iamniting iamniting changed the title [release-4.12] update the labels while updating the servicemonitor and prometheusrules Bug 2174335:[release-4.12] update the labels while updating the servicemonitor and prometheusrules Mar 20, 2023
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2023

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2174335, which is invalid:

  • expected the bug to target the "ODF 4.12.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2174335:[release-4.12] update the labels while updating the servicemonitor and prometheusrules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamniting
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2023

@iamniting: This pull request references Bugzilla bug 2174335, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.12.2) matches configured target release for branch (ODF 4.12.2)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ebenahar@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Mar 20, 2023
@openshift-ci openshift-ci bot mentioned this pull request Mar 21, 2023
Merged
@iamniting
Copy link
Member

/test ocs-operator-bundle-e2e-aws

@openshift-ci openshift-ci bot mentioned this pull request Mar 21, 2023
Merged
@iamniting
update the labels while updating the servicemonitor and prometheusrules
7ab1ff3 
labels were not getting updated while updating the servicemonitor and
prometheusrules. Only Spec is the one which was getting updated. With
the fix labels will also get updated along with the spec.

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@iamniting
Do not append labels in the exporterLabels
5754774 
Appending labels in the exporterLabels creates problems as they get
added to the service (labels and selector) and serviceMonitor
(labels and selector) both. Instead we just want to append user labels
on the serviceMonitor (labels).

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@iamniting iamniting force-pushed the cherry-pick-1925-to-release-4.12 branch from 0a9acb0 to 5754774 Compare March 22, 2023 02:34
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2023

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws 5754774 link false /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ecfe997 into red-hat-storage:release-4.12 Mar 22, 2023
15 of 16 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2023

@openshift-cherrypick-robot: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2174335 has not been moved to the MODIFIED state.

In response to this:

Bug 2174335:[release-4.12] update the labels while updating the servicemonitor and prometheusrules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot mentioned this pull request Mar 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamniting iamniting iamniting approved these changes

Assignees

@iamniting iamniting

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@openshift-cherrypick-robot @iamniting @openshift-merge-robot