Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2174335:[release-4.12] remove namespace deps from the bundle #1966

Merged
merged 3 commits into from Mar 21, 2023
Merged

Bug 2174335:[release-4.12] remove namespace deps from the bundle #1966

merged 3 commits into from Mar 21, 2023

Conversation

iamniting
Copy link
Member

These changes will allow us to install operator in any namespace.

Signed-off-by: Nitin Goyal nigoyal@redhat.com

Manual cherry-pick of #1908

@iamniting
remove namespace deps from the bundle
c413cbf 
- remove service account namespace ref from the role bindings

Having service Account namespace in the role bindings prevent us
from installing the operator in another namespace. Removing it will
allow us to install the operator in any namespace.

- move ocs-metrics-exporter ClusterRole and Binding to the csv

The service account namespace ref is a required field in the
ClusterRoleBinding. It can be removed from the RoleBinding but
not from the ClusterRoleBinding. Keeping the namespace ref
prevents us from installing the operator in another namespace
because the service account namespace is hardcoded.

Moving the ClusterRole to the csv allows us to remove the
namespace ref and install the operator anywhere.

- remove hardcoded namespace from the metrics-exporter deployment

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@iamniting
update genrated manifests
0b9b1a4 
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2023

@iamniting: This pull request references Bugzilla bug 2174335, which is invalid:

  • expected the bug to target the "ODF 4.12.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2174335:[release-4.12] remove namespace deps from the bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2023
@iamniting
Copy link
Member Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2023

@iamniting: This pull request references Bugzilla bug 2174335, which is invalid:

  • expected the bug to target the "ODF 4.12.2" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamniting
Copy link
Member Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2023

@iamniting: This pull request references Bugzilla bug 2174335, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.12.2) matches configured target release for branch (ODF 4.12.2)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ebenahar@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamniting
fix code spell errors
ecad0fc 
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@agarwal-mudit
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit, iamniting

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [agarwal-mudit,iamniting]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iamniting
Copy link
Member Author

/test ocs-operator-bundle-e2e-aws

4 similar comments
@iamniting
Copy link
Member Author

/test ocs-operator-bundle-e2e-aws

@iamniting
Copy link
Member Author

/test ocs-operator-bundle-e2e-aws

@iamniting
Copy link
Member Author

/test ocs-operator-bundle-e2e-aws

@iamniting
Copy link
Member Author

/test ocs-operator-bundle-e2e-aws

@iamniting
Copy link
Member Author

looks like openshift ci is really mad, Will run it again in some time.

@iamniting
Copy link
Member Author

/test ocs-operator-bundle-e2e-aws

2 similar comments
@iamniting
Copy link
Member Author

/test ocs-operator-bundle-e2e-aws

@iamniting
Copy link
Member Author

/test ocs-operator-bundle-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023 •
edited

@iamniting: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws ecad0fc link false /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@iamniting
Copy link
Member Author

/test ocs-operator-bundle-e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit abe0336 into red-hat-storage:release-4.12 Mar 21, 2023
15 of 16 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023

@iamniting: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2174335 has not been moved to the MODIFIED state.

In response to this:

Bug 2174335:[release-4.12] remove namespace deps from the bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot mentioned this pull request Mar 22, 2023
Merged
@iamniting iamniting deleted the release-4.12 branch April 19, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@agarwal-mudit agarwal-mudit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iamniting @agarwal-mudit @openshift-merge-robot