Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'namespace' tag to queries #2004

Conversation

aruniiird
Copy link
Contributor

This will allow the results to be grouped by namespace and not dependent on any particular one.

Copy link
Contributor

@umangachapagain umangachapagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified if the results of both the queries is the same?

@aruniiird
Copy link
Contributor Author

Have you verified if the results of both the queries is the same?

Yes verified each query (even the alerts, but could not fire each and every alerts, so tested the query without the condition. ie for eg: 'SOME-QUERY' > 0.75, just tested the 'SOME-QUERY' part to see it is giving appropriate results or not)

This will allow the results to be grouped by namespace and not dependend
on any particular one.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
@aruniiird
Copy link
Contributor Author

Another related change added through PR:#2008
@umangachapagain ^

@umangachapagain
Copy link
Contributor

/test ci/prow/ocs-operator-bundle-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 17, 2023

@umangachapagain: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test ci-index-ocs-operator-bundle
  • /test images
  • /test latest-upstream-ci-index-latest-upstream-bundle
  • /test latest-upstream-images
  • /test ocs-operator-bundle-e2e-aws
  • /test ocs-operator-ci
  • /test verify-latest-csv

The following commands are available to trigger optional jobs:

  • /test red-hat-storage-ocs-ci-e2e-aws

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-red-hat-storage-ocs-operator-main-ci-index-ocs-operator-bundle
  • pull-ci-red-hat-storage-ocs-operator-main-images
  • pull-ci-red-hat-storage-ocs-operator-main-latest-upstream-ci-index-latest-upstream-bundle
  • pull-ci-red-hat-storage-ocs-operator-main-latest-upstream-images
  • pull-ci-red-hat-storage-ocs-operator-main-ocs-operator-bundle-e2e-aws
  • pull-ci-red-hat-storage-ocs-operator-main-ocs-operator-ci
  • pull-ci-red-hat-storage-ocs-operator-main-verify-latest-csv

In response to this:

/test ci/prow/ocs-operator-bundle-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@umangachapagain
Copy link
Contributor

/test ocs-operator-bundle-e2e-aws

@aruniiird
Copy link
Contributor Author

Good to go, let me know if anything to be changed

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aruniiird, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2023
@iamniting
Copy link
Member

/test ocs-operator-bundle-e2e-aws

@iamniting
Copy link
Member

/cherry-pick release-4.13

@openshift-cherrypick-robot

@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamniting
Copy link
Member

/test ocs-operator-bundle-e2e-aws

@openshift-cherrypick-robot

@iamniting: new pull request created: #2017

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamniting
Copy link
Member

/cherry-pick release-4.12

@openshift-cherrypick-robot

@iamniting: new pull request created: #2021

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants