New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 'namespace' tag to queries #2004
Added 'namespace' tag to queries #2004
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you verified if the results of both the queries is the same?
Yes verified each query (even the alerts, but could not fire each and every alerts, so tested the query without the condition. ie for eg: 'SOME-QUERY' > 0.75, just tested the 'SOME-QUERY' part to see it is giving appropriate results or not) |
This will allow the results to be grouped by namespace and not dependend on any particular one. Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
0ff9990
to
7069974
Compare
|
Another related change added through PR:#2008 |
|
/test ci/prow/ocs-operator-bundle-e2e-aws |
|
@umangachapagain: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test ocs-operator-bundle-e2e-aws |
|
Good to go, let me know if anything to be changed |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aruniiird, umangachapagain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test ocs-operator-bundle-e2e-aws |
|
/cherry-pick release-4.13 |
|
@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test ocs-operator-bundle-e2e-aws |
|
@iamniting: new pull request created: #2017 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.12 |
|
@iamniting: new pull request created: #2021 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This will allow the results to be grouped by namespace and not dependent on any particular one.