Change any embedded namespace to current one #2008
Conversation
|
@iamniting , @umangachapagain , please take a look... |
|
/test ocs-operator-bundle-e2e-aws |
|
@umangachapagain , please take a look... |
In local prometheus yaml file, we have 'openshift-storage' namespace embedded into the file. This change will make sure we have the current namespace in the YAML file. As the function is general, it can be extended to do more sophisticated regex based replacements. Tests added. Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
aruniiird
force-pushed
the
change-to-current-namespace-in-prometheus-yaml
branch
from
d697a27
to
8f09854
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aruniiird, umangachapagain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/cherry-pick release-4.13 |
|
@umangachapagain: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@umangachapagain: new pull request created: #2016 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.12 |
|
@iamniting: new pull request created: #2020 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In local prometheus yaml file, we have 'openshift-storage' namespace embedded into the file. This change will make sure we have the current namespace in the YAML file.
As the function is general, it can be extended to do more sophisticated regex based replacements.
Tests added.