New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2186443:[release-4.12] remove storageClassClaim and add new storageClassRequest CR #2009
Bug 2186443:[release-4.12] remove storageClassClaim and add new storageClassRequest CR #2009
Conversation
from 4.13 we are moving from storageClassClaim to storageClassRequest CR. Also, we don't need consumer mode code in ocs-operator now, new operator will have consumer. Signed-off-by: subhamkrai <srai@redhat.com> (cherry picked from commit 55e5c08)
Signed-off-by: subhamkrai <srai@redhat.com>
Signed-off-by: subhamkrai <srai@redhat.com>
Signed-off-by: subhamkrai <srai@redhat.com>
|
@subhamkrai: This pull request references Bugzilla bug 2186443, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
golangci lint errors are not coming from my changes so not making part of this pr since it is already a big pr. Thanks |
|
/bugzilla refresh |
|
@subhamkrai: This pull request references Bugzilla bug 2186443, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@subhamkrai Can you look at the failures? |
|
@subhamkrai can you please check @iamniting comment? |
|
/bugzilla refresh |
|
@iamniting: This pull request references Bugzilla bug 2186443, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: jilju. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: subhamkrai <srai@redhat.com>
|
@iamniting ptal |
|
@subhamkrai: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, subhamkrai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
693f31e
into
red-hat-storage:release-4.12
|
@subhamkrai: All pull requests linked via external trackers have merged: Bugzilla bug 2186443 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
see individual commits