generate latest yamls ClusterObjectStoreState Alert #2054
Conversation
Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
|
/cherry-pick release-4.13 |
|
@agarwal-mudit: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
This should be auto generated from jsonnet using the make target. Why is this a manual change? @weirdwiz
yes, but somehow this file didn't get committed in that PR. it would be good to have a safeguard for this in the CI. current verify-generated-changes don't check for the alerts. I wanted to make changes in the existing verify makefile target, but the dependency only has files that were generated using controller-gen. Not sure if it's a good place to add. Or do you think I'm missing a piece? wdyt @umangachapagain |
|
@weirdwiz for prometheus rules, you need to run |
|
@umangachapagain made changes to only run the CI when files change in |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umangachapagain, weirdwiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@umangachapagain can you run the github action sanity check again? |
|
@agarwal-mudit: new pull request created: #2062 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.