Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1835125: [release-4.4] Always reconcile operator SCCs #516

Merged
merged 1 commit into from May 15, 2020
Merged

Bug 1835125: [release-4.4] Always reconcile operator SCCs #516

merged 1 commit into from May 15, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #515

/assign jarrpa

@jarrpa
Always reconcile operator SCCs
59ed800 
The operator SCCs should be verified at every reconcile, not just
created once.

Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 15, 2020
Merged
@jarrpa jarrpa changed the title [release-4.4] Always reconcile operator SCCs Bug 1835125: [release-4.4] Always reconcile operator SCCs May 15, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label May 15, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1835125, which is invalid:

  • expected the bug to target the "OCS 4.4.0" release, but it targets "---" instead
  • expected Bugzilla bug 1835125 to depend on a bug targeting a release in 4.5.0, 4.5.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1835125: [release-4.4] Always reconcile operator SCCs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 15, 2020
@jarrpa jarrpa added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 15, 2020
obnoxxx
obnoxxx approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: obnoxxx, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 15, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws 59ed800 link /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@obnoxxx
Copy link
Contributor

obnoxxx commented May 15, 2020

/override ci/prow/red-hat-storage-ocs-ci-e2e-aws

@openshift-ci-robot
Copy link

@obnoxxx: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • ci/prow/red-hat-storage-ocs-ci-e2e-aws

Only the following contexts were expected:

  • ci/prow/images
  • ci/prow/ocs-operator-ci
  • ci/prow/ocs-operator-e2e-aws
  • ci/prow/red-hat-storage-ocs-ci-e2e-aws
  • tide

In response to this:

/override ci/prow/red-hat-storage-ocs-ci-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@obnoxxx
Copy link
Contributor

obnoxxx commented May 15, 2020

/override ci/prow/ocs-operator-e2e-aws

@openshift-ci-robot
Copy link

@obnoxxx: Overrode contexts on behalf of obnoxxx: ci/prow/ocs-operator-e2e-aws

In response to this:

/override ci/prow/ocs-operator-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@obnoxxx obnoxxx merged commit 547932b into red-hat-storage:release-4.4 May 15, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: . Bugzilla bug 1835125 has been moved to the POST state.

In response to this:

Bug 1835125: [release-4.4] Always reconcile operator SCCs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obnoxxx obnoxxx obnoxxx approved these changes

@egafford egafford Awaiting requested review from egafford

Assignees

@jarrpa jarrpa

@obnoxxx obnoxxx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@openshift-cherrypick-robot @openshift-ci-robot @openshift-bot @obnoxxx @jarrpa