Delete the storageclasses during uninstall #556
Conversation
raghavendra-talur
force-pushed
the
rtalur-delete-resources
branch
2 times, most recently
from
7333390
to
b6a23fa
Compare
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
raghavendra-talur
force-pushed
the
rtalur-delete-resources
branch
from
b6a23fa
to
92614f8
Compare
|
@raghavendra-talur - what's the reason for holding the PR? The code looks good from a superficial look. |
| switch { | ||
| case err == nil: | ||
| if existing.DeletionTimestamp != nil { | ||
| reqLogger.Info(fmt.Sprintf("StorageClass %s is already marked for deletion", existing.Name)) |
There was a problem hiding this comment.
should we exit the flow here? Or do you want to schedule deletion again?
There was a problem hiding this comment.
Thanks, updated.
The reconcile loop has grown a lot and with more additions coming in it would be better to handle them in a separate function. Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
|
/unhold |
openshift-ci-robot
removed
the
do-not-merge/hold
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
raghavendra-talur
force-pushed
the
rtalur-delete-resources
branch
from
92614f8
to
c9e91fa
Compare
While testing manually I thought I found an error but turned out to be correct. I have addressed other comment too and think it is good for review. @jarrpa @obnoxxx The storageclass for Noobaa isn't created by ocs-operator and therefore isn't handled in this PR. I need to check more on that. |
|
/retest |
1 similar comment
|
/retest |
|
@raghavendra-talur: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: obnoxxx, raghavendra-talur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test ocs-operator-e2e-aws |
|
/cherrypick release-4.5 |
|
@raghavendra-talur: new pull request created: #574 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
At the time of installation, storageclasses are created for ceph-rbd and cephfs. We remove the same in the uninstall stage.
Failure to delete them is not considered fatal and does not block the uninstallation.