Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1849105: [release-4.5] StorageCluster: delete the default node selector labels during uninstall #576

Merged
merged 3 commits into from Jun 30, 2020
Merged

Bug 1849105: [release-4.5] StorageCluster: delete the default node selector labels during uninstall #576

merged 3 commits into from Jun 30, 2020

Conversation

raghavendra-talur
Copy link
Contributor

This is a cherry-pick of #558 .

To be merged after

#575 and #574

@openshift-ci-robot
Copy link

@raghavendra-talur: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.5] StorageCluster: delete the default node selector labels during uninstall

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@raghavendra-talur raghavendra-talur changed the title [release-4.5] StorageCluster: delete the default node selector labels during uninstall Bug 1849105: [release-4.5] StorageCluster: delete the default node selector labels during uninstall Jun 22, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Jun 22, 2020
@openshift-ci-robot
Copy link

@raghavendra-talur: This pull request references Bugzilla bug 1849105, which is invalid:

  • expected the bug to target the "OCS 4.5.0" release, but it targets "---" instead
  • expected Bugzilla bug 1849105 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1849105: [release-4.5] StorageCluster: delete the default node selector labels during uninstall

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 22, 2020
@raghavendra-talur raghavendra-talur mentioned this pull request Jun 22, 2020
Merged
@raghavendra-talur
Copy link
Contributor Author

/assign raghavendra-talur
@jarrpa @obnoxxx Please take a look.

@jarrpa
Copy link
Member

jarrpa commented Jun 23, 2020

/lgtm
/test ocs-operator-e2e-aws

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 23, 2020
@jarrpa
Copy link
Member

jarrpa commented Jun 23, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Jun 23, 2020
@openshift-ci-robot
Copy link

@jarrpa: This pull request references Bugzilla bug 1849105, which is invalid:

  • expected Bugzilla bug 1849105 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jarrpa jarrpa added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 23, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2020
@raghavendra-talur
extract function to get eligible nodes
8f856fa 
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
(cherry picked from commit 615b14e)
@raghavendra-talur
StorageCluster: simplify query to list nodes
a7f87f5 
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
(cherry picked from commit f668358)
@raghavendra-talur
StorageCluster: delete the default node selector labels
ae90547 
... at the time of uninstallation. If the StorageCluster spec provided a
list of node selector labels or expressions, we don't remove them
because a subset of them might be used by the user for other services
too.

Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
(cherry picked from commit 2195868)
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 30, 2020
@raghavendra-talur
Copy link
Contributor Author

@jarrpa I rebased this one now. Will wait for it to merge before rebasing #557

@openshift-ci-robot
Copy link

@raghavendra-talur: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws ae90547 link /test red-hat-storage-ocs-ci-e2e-aws
ci/prow/ocs-operator-e2e-aws ae90547 link /test ocs-operator-e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jarrpa
jarrpa approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2020
@jarrpa
Copy link
Member

jarrpa commented Jun 30, 2020

/test ocs-operator-e2e-aws

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa, raghavendra-talur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5e6b99c into red-hat-storage:release-4.5 Jun 30, 2020
@openshift-ci-robot
Copy link

@raghavendra-talur: All pull requests linked via external trackers have merged: . Bugzilla bug 1849105 has been moved to the POST state.

In response to this:

Bug 1849105: [release-4.5] StorageCluster: delete the default node selector labels during uninstall

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@raghavendra-talur raghavendra-talur deleted the rtalur-backport-558 branch September 2, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrpa jarrpa jarrpa approved these changes

@egafford egafford Awaiting requested review from egafford

@obnoxxx obnoxxx Awaiting requested review from obnoxxx

Assignees

@jarrpa jarrpa

@raghavendra-talur raghavendra-talur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@raghavendra-talur @openshift-ci-robot @jarrpa @openshift-bot @umangachapagain @openshift-merge-robot