Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1873580: Remove StorageClusterInitialization #833

Merged
merged 7 commits into from Oct 14, 2020
Merged

[release-4.6] Bug 1873580: Remove StorageClusterInitialization #833

merged 7 commits into from Oct 14, 2020

Conversation

jarrpa
Copy link
Member

@jarrpa jarrpa commented Oct 14, 2020 •
edited

We want finer control over which resources we reconcile and which we don't. This PR removes the need for a StorageClusterInitialization CR by implementing a set of string to control how a given type of resource is reconciled. The default is set to only reconcile if it doesn't exist, to maintain compatibility with current behavior on upgrade.

This PR includes backports for #789, #811, #822, and #834

@jarrpa
must-gather: Fix shellcheck errors in gather_noobaa_resources
e18d352 
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
@jarrpa
Refactor ensureSnapshotClasses()
ae471e7 
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
@jarrpa
Remove StorageClusterInitialization
7f98814 
This commit removes the need for a StorageClusterInitialization CR by
replacing it with a set of strings to controll the reconciliation of
previously initialized CRs. This changes the behavior for reapplying the
initialization, requiring the admin to set each resource's strategy to
"manage", wait for reconciliation, then back to "" or "default".

Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
@jarrpa
make update-generated for removing StorageClusterInitialization
5826d44 
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
@jarrpa
CSV changes to remove StorageClusterInitialization
6bda134 
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 14, 2020
@openshift-ci-robot
Copy link

@jarrpa: This pull request references Bugzilla bug 1873580, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "OCS 4.6.0" instead
  • expected Bugzilla bug 1873580 to depend on a bug targeting a release in 4.7.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 1873580: Remove StorageClusterInitialization

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jarrpa jarrpa added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 14, 2020
obnoxxx
obnoxxx approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks for the backport!

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 14, 2020
@nbalacha @jarrpa
Set failuredomain in storagecluster.status
a6157b8 
The storageCluster.status.failuredomain was empty causing
the cephblockpool.spec.failuredomain to be empty as well.

Signed-off-by: N Balachandran <nibalach@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2020
obnoxxx
obnoxxx approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2020
@jarrpa
Add missing CSV changes for removing StorageClusterInitialization
1655704 
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed lgtm Indicates that a PR is ready to be merged. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 14, 2020
@openshift-ci-robot
Copy link

@jarrpa: This pull request references Bugzilla bug 1873580, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "OCS 4.6.0" instead
  • expected Bugzilla bug 1873580 to depend on a bug targeting a release in 4.7.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 1873580: Remove StorageClusterInitialization

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

obnoxxx
obnoxxx approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Now it should be complete... :-)

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: obnoxxx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jarrpa
Copy link
Member Author

jarrpa commented Oct 14, 2020

/test ocs-operator-ci

@obnoxxx obnoxxx removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 14, 2020
@obnoxxx obnoxxx added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 14, 2020
@obnoxxx
Copy link
Contributor

obnoxxx commented Oct 14, 2020

/test ocs-operator-ci

@openshift-merge-robot
Copy link
Contributor

@jarrpa: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws 1655704 link /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b3bdac0 into red-hat-storage:release-4.6 Oct 14, 2020
@openshift-ci-robot
Copy link

@jarrpa: All pull requests linked via external trackers have merged:

Bugzilla bug 1873580 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1873580: Remove StorageClusterInitialization

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obnoxxx obnoxxx obnoxxx approved these changes

@crombus crombus Awaiting requested review from crombus

@umangachapagain umangachapagain Awaiting requested review from umangachapagain

Assignees

@obnoxxx obnoxxx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jarrpa @openshift-ci-robot @obnoxxx @openshift-merge-robot @nbalacha