Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1886709: [release-4.6]: Fix errors in managed resources reconciliation #871

Merged
merged 2 commits into from Oct 28, 2020
Merged

Bug 1886709: [release-4.6]: Fix errors in managed resources reconciliation #871

merged 2 commits into from Oct 28, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #856

/assign agarwal-mudit

@jarrpa
Fix erroneous spec references for managed resources
fcbc786 
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
@jarrpa
storageclass: Don't copy metadata from existing resource
b476499 
This resolves an issue where StorageClassed weren't being recreated
after deletion because we were copying over ResourceVersion, which is
not allowed for Create(). We shouldn't need this anyway, since we
generate all the relevant metadata already.

Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 28, 2020
Merged
@agarwal-mudit
Copy link
Member

/retitle Bug 1886709: [release-4.6]: Fix errors in managed resources reconciliation

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Fix errors in managed resources reconciliation Bug 1886709: [release-4.6]: Fix errors in managed resources reconciliation Oct 28, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Oct 28, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1886709, which is invalid:

  • expected Bugzilla bug 1886709 to depend on a bug targeting a release in 4.7.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1886709: [release-4.6]: Fix errors in managed resources reconciliation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 28, 2020
@openshift-merge-robot
Copy link
Contributor

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws b476499 link /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@obnoxxx obnoxxx added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 28, 2020
obnoxxx
obnoxxx approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: obnoxxx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit 215e400 into red-hat-storage:release-4.6 Oct 28, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1886709 has been moved to the MODIFIED state.

In response to this:

Bug 1886709: [release-4.6]: Fix errors in managed resources reconciliation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obnoxxx obnoxxx obnoxxx approved these changes

@jarrpa jarrpa Awaiting requested review from jarrpa

Assignees

@obnoxxx obnoxxx

@agarwal-mudit agarwal-mudit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @agarwal-mudit @openshift-ci-robot @openshift-merge-robot @obnoxxx @jarrpa