Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall will wait untill all PVs using OCS storageClasses are removed #152

Merged
merged 1 commit into from Mar 30, 2022

Conversation

bindrad
Copy link
Member

@bindrad bindrad commented Mar 30, 2022

Signed-off-by: bindrad dbindra@redhat.com

Comment on lines +209 to +214
PersistentVolumeSource: corev1.PersistentVolumeSource{
RBD: &corev1.RBDPersistentVolumeSource{
CephMonitors: []string{
"0.0.0.0:6789",
},
RBDImage: "test",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the source should be CSI, not RBD nor Cephfs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is just for our unit tests, we just need to make sure that the PVs are using OCS storage classes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Dhruv on this one, our unit tests are mocking the stoagecluster and as such we have no notion of CSI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is just for our unit tests, we just need to make sure that the PVs are using OCS storage classes

there is no relationship between the OCS storageclasses and the PersistentVolumeSource which is RBD and Cephfs mentioned here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree but we just want PVs using OCS storageClasses
It doesn't matter what PersistentVolumeSource we use

controllers/managedocs_controller.go Outdated Show resolved Hide resolved
@nb-ohad nb-ohad merged commit 4463dfb into red-hat-storage:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants