Added new metrics to be federated according to new alertRules #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on our call regarding this PR, I don't think it is possible to drop the label with specific key-value pair |
|
@bindrad does this pr needs a re-work? |
|
leelavg
reviewed
Jun 14, 2022
bindrad
force-pushed
the
fix-alerts
branch
5 times, most recently
from
629ac88
to
f0dd6e3
Compare
…ated metric relabelling
This fixes two alerts
1. CephMonQuorumLost
2. CephMgrIsMissingReplicas
The metrics that have pod label whose value is prometheus-k8s-0 or prometheus-k8s-1 will be replaced with blank value.
Metric before change:
kube_pod_status_phase{container="kube-rbac-proxy-main", endpoint="https-main", job="kube-state-metrics", namespace="openshift-monitoring", phase="Succeeded", pod="prometheus-k8s-1", prometheus="openshift-monitoring/k8s", service="kube-state-metrics", uid="071feb6a-7d97-4ec3-93fd-938d27c5a097"}
Metrics after change:
kube_pod_status_phase{container="kube-rbac-proxy-main", endpoint="https-main", job="kube-state-metrics", namespace="openshift-monitoring", phase="Succeeded", prometheus="openshift-monitoring/k8s", service="kube-state-metrics", uid="071feb6a-7d97-4ec3-93fd-938d27c5a097"}
Signed-off-by: bindrad <dbindra@redhat.com>
nb-ohad
approved these changes
Jun 15, 2022
|
@nb-ohad This PR can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two alerts
As there are two replicas of the Prometheus pod in the openshift-monitoring namespace and when we execute PersistentVolumeUsageNearFull and PersistentVolumeUsageCritical alertRule we get this error
Error executing query: found duplicate series for the match group {storageclass="ocs-storagecluster-cephfs"} on the right hand-side of the operation: [{__name__="kube_storageclass_info", container="kube-rbac-proxy-main", endpoint="https-main", job="kube-state-metrics", namespace="openshift-monitoring", prometheus="openshift-monitoring/k8s", provisioner="openshift-storage.cephfs.csi.ceph.com", reclaim_policy="Delete", service="kube-state-metrics", storageclass="ocs-storagecluster-cephfs", volume_binding_mode="Immediate"}, {__name__="kube_storageclass_info", container="kube-rbac-proxy-main", endpoint="https-main", job="kube-state-metrics", namespace="openshift-monitoring", pod="prometheus-k8s-1", prometheus="openshift-monitoring/k8s", provisioner="openshift-storage.cephfs.csi.ceph.com", reclaim_policy="Delete", service="kube-state-metrics", storageclass="ocs-storagecluster-cephfs", volume_binding_mode="Immediate"}];many-to-many matching not allowed: matching labels must be unique on one sideso we added labeldrop for pod label.But now CephMonQuorumLost alert requires pod label so we are relabelling in such a way that the metrics that have pod label whose value is prometheus-k8s-0 or prometheus-k8s-1 will be replaced with blank value.
Signed-off-by: bindrad dbindra@redhat.com