add number increment input for sync interval #493
Conversation
| const syncTime = isNaN(+target.value) ? minSyncTime : Number(target.value); | ||
| const normalizedSyncTime = syncTime < minSyncTime ? minSyncTime : syncTime; |
There was a problem hiding this comment.
The minimum value won't allow Null, also there is no change of syncTime < minSyncTime. Is these two conditions required?
There was a problem hiding this comment.
there are 2 ways to change value:
- increment or decrement using button, in this case onMinus/onPlus will be called.
- by directly typing in the value in the numberInput box, in this case onChange will be called. But, if user types negative value or less than 0 it will not allow that.
There was a problem hiding this comment.
I can remove point 2. if u think it is not needed... then user can only increase value by 1 at a time...
using increment or decrement button.
There was a problem hiding this comment.
yes second one is not required, first one is fine
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GowthamShanmugam, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.12 |
|
@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.12-compatibility |
|
@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of release-4.12-compatibility in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test odf-console-e2e-aws |
7 similar comments
|
/test odf-console-e2e-aws |
|
/test odf-console-e2e-aws |
|
/test odf-console-e2e-aws |
|
/test odf-console-e2e-aws |
|
/test odf-console-e2e-aws |
|
/test odf-console-e2e-aws |
|
/test odf-console-e2e-aws |
|
/retest |
openshift-merge-robot
merged commit 0b492eb
into
red-hat-storage:master
|
@SanjalKatiyar: new pull request created: #505 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@SanjalKatiyar: new pull request created: #506 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://bugzilla.redhat.com/show_bug.cgi?id=2114501
