Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version info to package.json file #881

Merged
merged 1 commit into from May 30, 2023

Conversation

bipuladh
Copy link
Contributor

Fixes BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2209364
Screenshot from container:

Screenshot from 2023-05-30 15-28-59

Fixes BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2209364

Signed-off-by: Bipul Adhikari <badhikar@redhat.com>
@bipuladh
Copy link
Contributor Author

Apparently WebpackConsolePlugin picks up the version from package.json and not from console-plugin.json file.

@bipuladh
Copy link
Contributor Author

/cherrypick release-4.13
/cherrypick release-4.13-compatibility

@openshift-cherrypick-robot

@bipuladh: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.13
/cherrypick release-4.13-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, GowthamShanmugam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, GowthamShanmugam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bipuladh
Copy link
Contributor Author

/override ci/prow/odf-console-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

@bipuladh: Overrode contexts on behalf of bipuladh: ci/prow/odf-console-e2e-aws

In response to this:

/override ci/prow/odf-console-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit cff6c9f into red-hat-storage:master May 30, 2023
6 checks passed
@openshift-cherrypick-robot

@bipuladh: new pull request created: #882

In response to this:

/cherrypick release-4.13
/cherrypick release-4.13-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bipuladh
Copy link
Contributor Author

/cherrypick release-4.13-compatibility

@openshift-cherrypick-robot

@bipuladh: new pull request created: #883

In response to this:

/cherrypick release-4.13
/cherrypick release-4.13-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bipuladh: new pull request could not be created: failed to create pull request against red-hat-storage/odf-console#release-4.13-compatibility from head openshift-cherrypick-robot:cherry-pick-881-to-release-4.13-compatibility: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-881-to-release-4.13-compatibility."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherrypick release-4.13-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants