Bug 2216707: Fixes for topology view for external mode #902
Conversation
bipuladh
commented
Jun 15, 2023
•
bipuladh
commented
bipuladh
force-pushed
the
topo-ext-fix
branch
2 times, most recently
from
b3e7c6c
to
33286b6
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
locales/en/plugin__odf-console.json
Outdated
| "Topology view is not supported for External Mode": "Topology view is not supported for External Mode", | ||
| "No StorageCluster found": "No StorageCluster found", | ||
| "Topology view is not supported for external mode": "Topology view is not supported for external mode", |
There was a problem hiding this comment.
same text twice ?? with "E" and "e" in external
| isExternalMode?: boolean; | ||
| }; | ||
|
|
||
| const TopologyViewErrorMessage: React.FC<TopologyViewEmptyStateProps> = ({ |
There was a problem hiding this comment.
shouldn't here the component name and the props type name be the same?
| {isExternalMode | ||
| ? t('Topology view is not supported for External Mode') | ||
| : t('No StorageCluster found')} | ||
| </Title> | ||
| <EmptyStateBody> | ||
| {t('Set up a storage cluster to view the topology')} | ||
| {isExternalMode | ||
| ? t('Topology view is not supported for external mode') | ||
| : t('Set up a storage cluster to view the topology')} | ||
| </EmptyStateBody> |
There was a problem hiding this comment.
same title and description for external mode ??
also, "E" and "e" in external in both texts...
There was a problem hiding this comment.
yes as per UXD team we can remove the description updating it.
bipuladh
changed the title
|
@bipuladh: This pull request references Bugzilla bug 2216707, which is valid. No validations were run on this bugRequesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: PrasadDesala. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Bipul Adhikari <badhikar@redhat.com>
|
@bipuladh: This pull request references Bugzilla bug 2216707, which is valid. No validations were run on this bugRequesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: PrasadDesala. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
openshift-merge-robot
merged commit 53b0b66
into
red-hat-storage:master
|
/cherry-pick release-4.13 |
|
/cherry-pick release-4.13-compatibility |
|
@SanjalKatiyar: new pull request created: #908 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@SanjalKatiyar: new pull request created: #909 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
