After hub recovery, cant initiate failover #932
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GowthamShanmugam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@GowthamShanmugam: This pull request references Bugzilla bug 2209288, which is valid. No validations were run on this bugRequesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: parikshithb. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
GowthamShanmugam
changed the title
|
/hold |
GowthamShanmugam
force-pushed
the
2209288
branch
from
3216abf
to
4ea6a12
Compare
GowthamShanmugam
changed the title
|
/hold cancel |
packages/mco/utils/acm.ts
Outdated
| placementDecision: ACMPlacementDecisionKind, | ||
| drPlacementControl: DRPlacementControlKind | ||
| ): string[] => { | ||
| if (placementDecision?.status.decisions.length > 0) { |
There was a problem hiding this comment.
do we need to do this or its guaranteed that if "status" is present then "decisions" will be present as well ??
| if (placementDecision?.status.decisions.length > 0) { | |
| if ((placementDecision ?? {}).status?.decisions?.length > 0) { |
|
so, this annotation will never get removed ?? not even during hub recovery ?? |
When ramen starts to reconcile, it will add the annotation immediately. In hub recovery, they will get this info from s3 object storage and display it as a last-remembered application cluster. |
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2209288 Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>
GowthamShanmugam
force-pushed
the
2209288
branch
from
4ea6a12
to
c53734a
Compare
|
/lgtm |
GowthamShanmugam
changed the title
|
@GowthamShanmugam: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.14 |
|
@GowthamShanmugam: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@GowthamShanmugam: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.14-compatibility |
|
@GowthamShanmugam: once the present PR merges, I will cherry-pick it on top of release-4.14-compatibility in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test odf-console-e2e-aws |
1 similar comment
|
/test odf-console-e2e-aws |
|
@GowthamShanmugam: new pull request created: #956 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@GowthamShanmugam: new pull request created: #957 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2209288