Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2079866: Remove invalid arg from odf-multicluster-console deployment #109

Conversation

GowthamShanmugam
Copy link
Contributor

Signed-off-by: Gowtham Shanmugasundaram gshanmug@redhat.com

Comment on lines -281 to -282
- args:
- --ssl --cert=/var/serving-cert/tls.crt --key=/var/serving-cert/tls.key
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switched to Nginx to run odf-multicluster-console, and it will takecare of passing these certificates: https://github.com/red-hat-storage/odf-console/blob/master/default.conf

@GowthamShanmugam GowthamShanmugam changed the title Remove invalid arg from odf-multicluster-console deployment Bug 2079866: Remove invalid arg from odf-multicluster-console deployment Apr 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2022

@GowthamShanmugam: This pull request references Bugzilla bug 2079866, which is valid.

No validations were run on this bug

Requesting review from QA contact:
/cc @keesturam

In response to this:

Bug 2079866: Remove invalid arg from odf-multicluster-console deployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2022

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@GowthamShanmugam: This pull request references Bugzilla bug 2079866, which is valid.

No validations were run on this bug

Requesting review from QA contact:
/cc @keesturam

In response to this:

Bug 2079866: Remove invalid arg from odf-multicluster-console deployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@GowthamShanmugam
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2022

@GowthamShanmugam: This pull request references Bugzilla bug 2079866, which is valid.

No validations were run on this bug

Requesting review from QA contact:
/cc @keesturam

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2022

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@GowthamShanmugam: This pull request references Bugzilla bug 2079866, which is valid.

No validations were run on this bug

Requesting review from QA contact:
/cc @keesturam

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@GowthamShanmugam
Copy link
Contributor Author

/retest

Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>
@vbnrh
Copy link
Member

vbnrh commented May 2, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label May 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GowthamShanmugam, vbnrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 2, 2022
@openshift-merge-robot openshift-merge-robot merged commit d49c0cc into red-hat-storage:main May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants