Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2087145: [release-4.10] Add bindings for spoke users on hub #114

Conversation

vbnrh
Copy link
Member

@vbnrh vbnrh commented May 17, 2022

This commit adds changes that binds the hub's clusterrole to generated
spoke users.

This is done to fix a bug where the tokenagent on the spokeclusters are
unable to watch and make channges to mirrorpeer on the hub

Signed-off-by: Vineet Badrinath vineetbnath@gmail.com

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2022

@vbnrh: This pull request references Bugzilla bug 2082078, which is invalid:

  • expected the bug to target the "ODF 4.10.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2082078: [release-4.10] Add bindings for spoke users on hub

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This commit adds changes that binds the hub's clusterrole to generated
spoke users.

This is done to fix a bug where the tokenagent on the spokeclusters are
unable to watch and make channges to mirrorpeer on the hub

Signed-off-by: Vineet Badrinath <vineetbnath@gmail.com>
@vbnrh vbnrh force-pushed the add-spoke-users-on-hub-4.10 branch from d6d55c5 to 4385d73 Compare May 17, 2022 05:53
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umangachapagain, vbnrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vbnrh
Copy link
Member Author

vbnrh commented May 17, 2022

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2022

@vbnrh: This pull request references Bugzilla bug 2082078, which is invalid:

  • expected the bug to target the "ODF 4.10.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vbnrh
Copy link
Member Author

vbnrh commented May 17, 2022

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2022

@vbnrh: This pull request references Bugzilla bug 2082078, which is invalid:

  • expected the bug to target the "ODF 4.10.1" release, but it targets "ODF 4.10.3" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agarwal-mudit
Copy link
Member

/hold
z-streams PR cannot be merged like this, we need a BZ with all the acks

@agarwal-mudit agarwal-mudit changed the title Bug 2082078: [release-4.10] Add bindings for spoke users on hub Bug 2087145: [release-4.10] Add bindings for spoke users on hub May 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2022

@vbnrh: This pull request references Bugzilla bug 2087145, which is invalid:

  • expected the bug to target the "ODF 4.10.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2087145: [release-4.10] Add bindings for spoke users on hub

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@umangachapagain
Copy link
Contributor

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2022

@umangachapagain: This pull request references Bugzilla bug 2087145, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.10.3) matches configured target release for branch (ODF 4.10.3)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2022

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@umangachapagain: This pull request references Bugzilla bug 2087145, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.10.3) matches configured target release for branch (ODF 4.10.3)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agarwal-mudit
Copy link
Member

/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit 91b1a7f into red-hat-storage:release-4.10 May 18, 2022
8 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2022

@vbnrh: All pull requests linked via external trackers have merged:

Bugzilla bug 2087145 has been moved to the MODIFIED state.

In response to this:

Bug 2087145: [release-4.10] Add bindings for spoke users on hub

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants