New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2005843: Label ODF multicluster operator pod based on deployment name #44
Bug 2005843: Label ODF multicluster operator pod based on deployment name #44
Conversation
|
@GowthamShanmugam: This pull request references Bugzilla bug 2005843, which is valid. No validations were run on this bugNo GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I dont know-how this PR #43 is closed, created a new PR with all the changes which we discussed. |
|
/lgtm |
|
@sp98: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to make changes manually.
Just add
# Labels to add to all resources and selectors.
commonLabels:
control-plane: odfmo-controller-manager
here:
| # These resources constitute the fully configured set of manifests |
and run make bundle. It will add labels to all generated resources.
Keep it in one commit.
ack |
Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>
Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>
4685025
to
8c64fc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GowthamShanmugam, umangachapagain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-4.9 |
|
@umangachapagain: new pull request created: #47 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Keep labels of one operator pods always unique from the other
operator pods, So that label based fetching of pods can be more
deterministic.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2005843