Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2005843: Label ODF multicluster operator pod based on deployment name #44

Merged
merged 2 commits into from Sep 22, 2021

Conversation

GowthamShanmugam
Copy link
Contributor

Keep labels of one operator pods always unique from the other
operator pods, So that label based fetching of pods can be more
deterministic.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2005843

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2021

@GowthamShanmugam: This pull request references Bugzilla bug 2005843, which is valid.

No validations were run on this bug

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request.

In response to this:

Bug 2005843: Label ODF multicluster operator pod based on deployment name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@GowthamShanmugam
Copy link
Contributor Author

@sp98 @umangachapagain

I dont know-how this PR #43 is closed, created a new PR with all the changes which we discussed.

@sp98
Copy link
Contributor

sp98 commented Sep 22, 2021

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2021

@sp98: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@umangachapagain umangachapagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to make changes manually.

Just add

# Labels to add to all resources and selectors.
commonLabels:
 control-plane: odfmo-controller-manager

here:

# These resources constitute the fully configured set of manifests

and run make bundle. It will add labels to all generated resources.
Keep it in one commit.

@GowthamShanmugam
Copy link
Contributor Author

# Labels to add to all resources and selectors.
commonLabels:
 control-plane: odfmo-controller-manager

ack

Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>
Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>
Copy link
Contributor

@umangachapagain umangachapagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GowthamShanmugam, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 52bc2b5 into red-hat-storage:main Sep 22, 2021
@umangachapagain
Copy link
Contributor

/cherrypick release-4.9

@openshift-cherrypick-robot

@umangachapagain: new pull request created: #47

In response to this:

/cherrypick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants