Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumped ramen depedency version #88

Merged
merged 1 commit into from Mar 22, 2022
Merged

Bumped ramen depedency version #88

merged 1 commit into from Mar 22, 2022

Conversation

GowthamShanmugam
Copy link
Contributor

Bump up the ramendepency version to adobt new changes in ramenconfig.

Signed-off-by: Gowtham Shanmugasundaram gshanmug@redhat.com

@GowthamShanmugam
Copy link
Contributor Author

/hold

@GowthamShanmugam
Copy link
Contributor Author

/hold cancel

GowthamShanmugam
GowthamShanmugam commented Mar 19, 2022
View reviewed changes
go.mod
github.com/spf13/cobra v1.1.3
github.com/stretchr/testify v1.7.0
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
k8s.io/api v0.22.1
k8s.io/apimachinery v0.22.1
k8s.io/api v0.22.6
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumping up ramen is increasing k8 version but in replace we are pointing old version of k8 already

GowthamShanmugam
GowthamShanmugam commented Mar 19, 2022
View reviewed changes
go.mod
k8s.io/api v0.22.1
k8s.io/apimachinery v0.22.1
k8s.io/api v0.22.6
k8s.io/apimachinery v0.22.6
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here in replace we are pointing told verison

GowthamShanmugam
GowthamShanmugam commented Mar 19, 2022
View reviewed changes
go.mod
sigs.k8s.io/cluster-api-provider-aws => github.com/openshift/cluster-api-provider-aws v0.2.1-0.20201022175424-d30c7a274820
sigs.k8s.io/cluster-api-provider-azure => github.com/openshift/cluster-api-provider-azure v0.1.0-alpha.3.0.20201016155852-4090a6970205
sigs.k8s.io/cluster-api-provider-openstack => github.com/openshift/cluster-api-provider-openstack v0.0.0-20201116051540-155384b859c5
sigs.k8s.io/controller-runtime => sigs.k8s.io/controller-runtime v0.9.6
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all changes in replacing is, I am reverting back to the already existing version. so all changes by the new ramen dependency is reverted back to old version.

umangachapagain
umangachapagain requested changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@umangachapagain umangachapagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only go.mod and go.sum files should be in this PR. Let's do the lint fix in a separate one.
It is not required for dependency issue which needs to be backported.

@GowthamShanmugam
Copy link
Contributor Author

Only go.mod and go.sum files should be in this PR. Let's do the lint fix in a separate one. It is not required for dependency issue which needs to be backported.

ack

@GowthamShanmugam
Bumped ramen depedency version
853d3aa 
Bump up the ramendepency version to adobt new changes in ramenconfig.

Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>
@GowthamShanmugam
Copy link
Contributor Author

GowthamShanmugam commented Mar 22, 2022 •
edited

@umangachapagain Changes done

@openshift-ci openshift-ci bot added the lgtm label Mar 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GowthamShanmugam, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agarwal-mudit
Copy link
Member

/retest
/cherry-pick release-4.10

@openshift-cherrypick-robot
Copy link

@agarwal-mudit: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

In response to this:

/retest
/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@umangachapagain
Copy link
Contributor

/retest

1 similar comment
@agarwal-mudit
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit d668de8 into red-hat-storage:main Mar 22, 2022
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 22, 2022
Merged
@openshift-cherrypick-robot
Copy link

@agarwal-mudit: new pull request created: #90

In response to this:

/retest
/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umangachapagain umangachapagain umangachapagain approved these changes

Assignees

@umangachapagain umangachapagain

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@GowthamShanmugam @agarwal-mudit @openshift-cherrypick-robot @umangachapagain @openshift-merge-robot