New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collect ceph and rbd logs from sys #52
base: main
Are you sure you want to change the base?
Conversation
This commit is to collect additional log files: /sys/bus/rbd and /sys/kernel/debug/ceph Signed-off-by: yati1998 <ypadia@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yati1998 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@yati1998: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| CEPH_LOG_OUTPUT_DIR=${CEPH_COLLECTION_PATH}/ceph_log_${node} | ||
| RBD_LOG_OUTPUT_DIR=${CEPH_COLLECTION_PATH}/rbd_log_${node} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not really logs:
| CEPH_LOG_OUTPUT_DIR=${CEPH_COLLECTION_PATH}/ceph_log_${node} | |
| RBD_LOG_OUTPUT_DIR=${CEPH_COLLECTION_PATH}/rbd_log_${node} | |
| LIBCEPH_OUTPUT_DIR=${CEPH_COLLECTION_PATH}/libceph_${node} | |
| RBD_OUTPUT_DIR=${CEPH_COLLECTION_PATH}/rbd_${node} |
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unneeded blank lines
| @@ -382,6 +382,10 @@ for ns in $namespaces; do | |||
| ceph_daemon_log_collection() { | |||
| dbglog "collecting Ceph daemon logs from node ${node}" | |||
| oc rsync -n "${ns}" "$(oc get pods -n "${ns}" --no-headers | grep "${node//./}-debug" | awk '{print $1}')":/host/var/lib/rook/"${ns}"/log "${CEPH_DAEMON_LOG_OUTPUT_DIR}" | |||
| oc rsync -n "${ns}" "$(oc get pods -n "${ns}" --no-headers | grep "${node//./}-debug" | awk '{print $1}')":/host/sys/kernel/debug/ceph "${CEPH_LOG_OUTPUT_DIR}" | |||
| oc rsync -n "${ns}" "$(oc get pods -n "${ns}" --no-headers | grep "${node//./}-debug" | awk '{print $1}')":/host/sys/bus/rbd "${RBD_LOG_OUTPUT_DIR}" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does oc rsync interact with symlinks? There is plenty of those under /sys/bus/rbd and we want that data too.
Could you please upload the resulting libceph_${node} and rbd_${node} directories somewhere after taking must-gather on a cluster with at least two active RBD PVs?
This commit is to collect additional
log files: /sys/bus/rbd and /sys/kernel/debug/ceph