Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect ceph and rbd logs from sys #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yati1998
Copy link
Member

This commit is to collect additional
log files: /sys/bus/rbd and /sys/kernel/debug/ceph

This commit is to collect additional
log files: /sys/bus/rbd and /sys/kernel/debug/ceph

Signed-off-by: yati1998 <ypadia@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yati1998

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2023

@yati1998: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/odf-must-gather 237de1d link true /test odf-must-gather

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Comment on lines +418 to +419
CEPH_LOG_OUTPUT_DIR=${CEPH_COLLECTION_PATH}/ceph_log_${node}
RBD_LOG_OUTPUT_DIR=${CEPH_COLLECTION_PATH}/rbd_log_${node}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not really logs:

Suggested change
CEPH_LOG_OUTPUT_DIR=${CEPH_COLLECTION_PATH}/ceph_log_${node}
RBD_LOG_OUTPUT_DIR=${CEPH_COLLECTION_PATH}/rbd_log_${node}
LIBCEPH_OUTPUT_DIR=${CEPH_COLLECTION_PATH}/libceph_${node}
RBD_OUTPUT_DIR=${CEPH_COLLECTION_PATH}/rbd_${node}

Comment on lines +387 to +388


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unneeded blank lines

@@ -382,6 +382,10 @@ for ns in $namespaces; do
ceph_daemon_log_collection() {
dbglog "collecting Ceph daemon logs from node ${node}"
oc rsync -n "${ns}" "$(oc get pods -n "${ns}" --no-headers | grep "${node//./}-debug" | awk '{print $1}')":/host/var/lib/rook/"${ns}"/log "${CEPH_DAEMON_LOG_OUTPUT_DIR}"
oc rsync -n "${ns}" "$(oc get pods -n "${ns}" --no-headers | grep "${node//./}-debug" | awk '{print $1}')":/host/sys/kernel/debug/ceph "${CEPH_LOG_OUTPUT_DIR}"
oc rsync -n "${ns}" "$(oc get pods -n "${ns}" --no-headers | grep "${node//./}-debug" | awk '{print $1}')":/host/sys/bus/rbd "${RBD_LOG_OUTPUT_DIR}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does oc rsync interact with symlinks? There is plenty of those under /sys/bus/rbd and we want that data too.

Could you please upload the resulting libceph_${node} and rbd_${node} directories somewhere after taking must-gather on a cluster with at least two active RBD PVs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants