Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction/Changes in Quick Start Guides for ODF #100

Merged
merged 1 commit into from Oct 12, 2021
Merged

Correction/Changes in Quick Start Guides for ODF #100

merged 1 commit into from Oct 12, 2021

Conversation

SanjalKatiyar
Copy link
Contributor

@SanjalKatiyar SanjalKatiyar commented Sep 28, 2021 •
edited

@SanjalKatiyar SanjalKatiyar force-pushed the edit_odf_quickstart branch 3 times, most recently from 6b8fc49 to 2db287f Compare October 5, 2021 13:46
@SanjalKatiyar
controllers: update ConsoleQuickStart guides
a717dd2 
Updates the ODF gettingStarted and odfConfigAndManagement QS guides.
Signed-off-by: sanjalkatiyar <sanjaldhir@gmail.com>
@SanjalKatiyar SanjalKatiyar changed the title [WIP] Bug 2004916 - Correction/Changes in Quick Start Guides for ODF Bug 2004916 - Correction/Changes in Quick Start Guides for ODF Oct 11, 2021
@SanjalKatiyar SanjalKatiyar changed the title Bug 2004916 - Correction/Changes in Quick Start Guides for ODF Bug 2004916: Correction/Changes in Quick Start Guides for ODF Oct 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2021

@SanjalKatiyar: This pull request references Bugzilla bug 2004916, which is valid.

No validations were run on this bug

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request.

In response to this:

Bug 2004916: Correction/Changes in Quick Start Guides for ODF

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vbnrh
Copy link
Member

vbnrh commented Oct 12, 2021

/approve
/assign @iamniting @jarrpa for lgtm

@jarrpa jarrpa changed the title Bug 2004916: Correction/Changes in Quick Start Guides for ODF Correction/Changes in Quick Start Guides for ODF Oct 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2021

@SanjalKatiyar: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Correction/Changes in Quick Start Guides for ODF

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jarrpa
jarrpa approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to use BZ numbers in commits to the main branch, they're only used for backports.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa, SanjalKatiyar, vbnrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2021
@jarrpa
Copy link
Member

jarrpa commented Oct 12, 2021

/cherrypick release-4.9

@openshift-cherrypick-robot
Copy link

@jarrpa: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 6a6a56b into red-hat-storage:main Oct 12, 2021
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 12, 2021
Merged
@openshift-cherrypick-robot
Copy link

@jarrpa: new pull request created: #112

In response to this:

/cherrypick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamniting iamniting added the backport-release-4.9 Indicate PR requires to be backported label Oct 13, 2021
@openshift-ci openshift-ci bot mentioned this pull request Feb 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrpa jarrpa jarrpa approved these changes

Assignees

@jarrpa jarrpa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-release-4.9 Indicate PR requires to be backported lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SanjalKatiyar @vbnrh @jarrpa @openshift-cherrypick-robot @iamniting @openshift-merge-robot