console: Fix basepath for odf-console deployment #144
Conversation
console/console.go
Outdated
| const MAIN_BASE_PATH = "" | ||
| const COMPATIBILITY_BASE_PATH = "compatibility" | ||
| const MAIN_BASE_PATH = "/" | ||
| const COMPATIBILITY_BASE_PATH = "/compatibility" |
There was a problem hiding this comment.
| const COMPATIBILITY_BASE_PATH = "/compatibility" | |
| const COMPATIBILITY_BASE_PATH = "/compatibility/" |
There were a couple of changes introduced in OCP 4.10 which caused the dynamic plugin to break. This patch fixes it. Signed-off-by: Vineet Badrinath <vineetbnath@gmail.com>
|
/lgtm |
|
/cherrypick release-4.9 |
|
@vbnrh: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, iamniting, vbnrh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@vbnrh: new pull request created: #145 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There were a couple of changes introduced in OCP 4.10 which caused the
dynamic plugin to break.
Signed-off-by: Vineet Badrinath vineetbnath@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=2022339