Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update storageCluster API #152

Merged
merged 2 commits into from Dec 13, 2021
Merged

Update storageCluster API #152

merged 2 commits into from Dec 13, 2021

Conversation

iamniting
Copy link
Member

@iamniting iamniting commented Dec 10, 2021 •
edited

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2021
jarrpa
jarrpa approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2021
@jarrpa
Copy link
Member

jarrpa commented Dec 10, 2021

If we are officially dropping support for go 1.15, we should update the CI to reflect that. Probably push another PR to disable it and then we can waive it here.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2021
@iamniting
godeps: update ocs-operator API
65630b6 
Storage Cluster API in the odf-operator does not have some of the newly
added fields because of which while updating from odf-operator it is
removing those fields from the k8s API server.
eg. Spec.MultiCloudGateway.DbStorageClassName

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@iamniting
godeps: update vendor dir
67ee9ed 
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (🤖 ). Happy coding!

@jarrpa
Copy link
Member

jarrpa commented Dec 10, 2021

/test unit-tests

3 similar comments
@iamniting
Copy link
Member Author

/test unit-tests

@iamniting
Copy link
Member Author

/test unit-tests

@iamniting
Copy link
Member Author

/test unit-tests

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2021

@iamniting: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-tests 67ee9ed link true /test unit-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jarrpa
Copy link
Member

jarrpa commented Dec 13, 2021

Changes look good... but it seems that a change in how controller-runtime is doing things caused our unit tests to break in a way that very few would run into. So of course we did! The following PR in the CI should help alleviate this: openshift/release#24507

@jarrpa
Copy link
Member

jarrpa commented Dec 13, 2021

Success!

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, jarrpa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 61ef53b into red-hat-storage:main Dec 13, 2021
@iamniting iamniting mentioned this pull request Dec 13, 2021
Merged
@jarrpa
Copy link
Member

jarrpa commented Dec 15, 2021

/cherrypick release-4.9

@openshift-cherrypick-robot
Copy link

@jarrpa: #152 failed to apply on top of branch "release-4.9":

Applying: godeps: update ocs-operator API
Applying: godeps: update vendor dir
error: mode change for vendor/github.com/rook/rook/pkg/apis/rook.io/v1/storage.go, which is not in current HEAD
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 godeps: update vendor dir
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamniting iamniting deleted the api-update branch December 19, 2021 15:09
@iamniting iamniting mentioned this pull request Jan 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrpa jarrpa jarrpa approved these changes

@afreen23 afreen23 Awaiting requested review from afreen23

Assignees

@jarrpa jarrpa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iamniting @jarrpa @openshift-cherrypick-robot @openshift-merge-robot