Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2031876:[release-4.9] godeps: update ocs-operator API #164

Merged
merged 3 commits into from Jan 13, 2022

Conversation

iamniting
Copy link
Member

@iamniting iamniting commented Jan 13, 2022

Storage Cluster API in the odf-operator does not have some of the newly
added fields because of which while updating from odf-operator it is
removing those fields from the k8s API server.
eg. Spec.MultiCloudGateway.DbStorageClassName

Signed-off-by: Nitin Goyal nigoyal@redhat.com

Backport of #152

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2022

@iamniting: This pull request references Bugzilla bug 2031876, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.9.2) matches configured target release for branch (ODF 4.9.2)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @ebenahar

In response to this:

Bug 2031876:[release-4.9]godeps: update ocs-operator API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2022

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: ebenahar.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@iamniting: This pull request references Bugzilla bug 2031876, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.9.2) matches configured target release for branch (ODF 4.9.2)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @ebenahar

In response to this:

Bug 2031876:[release-4.9]godeps: update ocs-operator API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2022

@iamniting: This pull request references Bugzilla bug 2031876, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.9.2) matches configured target release for branch (ODF 4.9.2)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @ebenahar

In response to this:

Bug 2031876:[release-4.9]godeps: update ocs-operator API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2022

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: ebenahar.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@iamniting: This pull request references Bugzilla bug 2031876, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.9.2) matches configured target release for branch (ODF 4.9.2)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @ebenahar

In response to this:

Bug 2031876:[release-4.9]godeps: update ocs-operator API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Storage Cluster API in the odf-operator does not have some of the newly
added fields because of which while updating from odf-operator it is
removing those fields from the k8s API server.
eg. Spec.MultiCloudGateway.DbStorageClassName

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@agarwal-mudit
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit, iamniting

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [agarwal-mudit,iamniting]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iamniting iamniting merged commit 62e8ced into red-hat-storage:release-4.9 Jan 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2022

@iamniting: All pull requests linked via external trackers have merged:

Bugzilla bug 2031876 has been moved to the MODIFIED state.

In response to this:

Bug 2031876:[release-4.9]godeps: update ocs-operator API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamniting iamniting deleted the api branch January 19, 2022 05:30
@iamniting iamniting changed the title Bug 2031876:[release-4.9]godeps: update ocs-operator API Bug 2031876:[release-4.9] godeps: update ocs-operator API Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high bugzilla/valid-bug lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants